After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743116 - Tab header's box-shadow leaks into open file
Tab header's box-shadow leaks into open file
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-18 08:40 UTC by Timm Bäder
Modified: 2015-01-18 23:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
css: Remove box-shadow in tab headers (1.38 KB, patch)
2015-01-18 08:41 UTC, Timm Bäder 		committed Details | Review

Description Timm Bäder 2015-01-18 08:40:44 UTC 
Small screencast of the problem: http://videobin.org/+8hk/bby.ogg

In Adwaita, a normal .button has an outside box-shadow applied that draws a 1px white line below it. The styling for the tab headers in builder doesn't remove them so they leak in to the open document when hovered (I assume the specificity remove them in the non-hovered case).

I'll attach a simple patch to remove the box shadow completely.



Note: In some cases, the box shadow seems to stick even if the button is not hovered. Not sure if that's a gtk+ problem or not and I can't reliably reproduce it :(
Comment 1 Timm Bäder 2015-01-18 08:41:43 UTC 
Created attachment 294775 [details] [review]
css: Remove box-shadow in tab headers

Any outside box shadow applied by Adwaita should not leak into the
open file.
Comment 2 Christian Hergert 2015-01-18 23:04:51 UTC 
We have some new designs being worked on that will probably change this a bunch, but either way looks good.

Thanks!

Attachment 294775 [details] pushed as 90b795e - css: Remove box-shadow in tab headers