After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742976 - Vim mode: Shift+# should select the entire word and launch begin-search signal
Vim mode: Shift+# should select the entire word and launch begin-search signal
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-15 15:22 UTC by Erick Perez Castellanos
Modified: 2015-03-12 23:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Erick Perez Castellanos 2015-01-15 15:22:31 UTC
When I press Shift+# in vim-mode I get the entire word marked, and every instance of it on the text.

It would be helpful it this allow me to cycle through those instances, like vim does.
Comment 1 Igor Gnatenko 2015-01-15 15:28:06 UTC
Nice spotted. Didn't know this feature in vim.This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Igor Gnatenko 2015-01-15 15:28:38 UTC
Sorry for confusing comment. It's not fixed.
Comment 3 Igor Gnatenko 2015-01-18 14:27:13 UTC
I just tested it and it works the same as in vim.


Feel free to reopen if it works not as expected. Thanks for bugreport.
Comment 4 Christian Hergert 2015-01-18 22:50:20 UTC
It's not totally perfect, as it stands now. It reselects your current word every time. And due to word boundaries in GtkSourceView, something like "FooBar" will match a word that is longer like "FooBarBaz". That is something we need to fix.
Comment 5 Erick Perez Castellanos 2015-01-19 14:35:30 UTC
(In reply to comment #3)
> I just tested it and it works the same as in vim.
> 
> 
> Feel free to reopen if it works not as expected. Thanks for bugreport.

No, it does not work as in vim. What Shift+# does in vim is select the word under the cursor and provide it to the search (adding word boundaries to the query). That way I can move thourgh every occurrences using n/N in vim. In Builder I can move between he occurrences only using Shift+#, but I know I can move thourgh occurrences on a search using the arrow keys.

What it should do is the same as in vim, launch a search with the word under the cursor.

There's no need for us to force the user to learn two differents ways of doing things (moving thourgh the occurrences of a search).
Comment 6 Igor Gnatenko 2015-01-19 15:28:41 UTC
ok, I understand this point.
Comment 7 Ray Strode [halfline] 2015-02-02 21:36:51 UTC
This has improved a bit since bug 743668 .  You can now do '#' and then use 'n' to go the next result.
Comment 8 Christian Hergert 2015-03-12 23:46:39 UTC
This is fixed on the wip/libide branch (in test-ide-source-view). Going to mark as closed, but it will be *really* fixed once we merge into the workbench shell and then master.