After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742966 - validate: launcher: Fix test log header output
validate: launcher: Fix test log header output
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other All
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-15 12:21 UTC by Ramiro Polla
Modified: 2015-06-24 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
validate: launcher: Fix test log header output (1.89 KB, patch)
2015-01-15 12:21 UTC, Ramiro Polla 		accepted-commit_now Details | Review
validate: launcher: Fix test log header output (1.83 KB, patch)
2015-01-16 15:14 UTC, Ramiro Polla 		committed Details | Review

Description Ramiro Polla 2015-01-15 12:21:01 UTC 
Currently gst-validate-launcher writes headers to the log files after the tests have already run, thus overwriting the beginning of the file. Attached patch writes the header before running the tests.
Comment 1 Ramiro Polla 2015-01-15 12:21:21 UTC 
Created attachment 294590 [details] [review]
validate: launcher: Fix test log header output
Comment 2 Thibault Saunier 2015-01-15 14:34:49 UTC 
Review of attachment 294590 [details] [review]:

::: validate/launcher/baseclasses.py
@@ -276,3 @@
         self.time_taken = time.time() - self._starting_time
 
-        if not self.reporter.uses_standard_output():

So you write it in stdout if it is what is used? (not a big deal anyway!)
Comment 3 Ramiro Polla 2015-01-15 16:12:25 UTC 
Review of attachment 294590 [details] [review]:

::: validate/launcher/baseclasses.py
@@ -276,3 @@
         self.time_taken = time.time() - self._starting_time
 
-        if not self.reporter.uses_standard_output():

The place where this code is moved to is already protected with !stdout.
Comment 4 Thibault Saunier 2015-01-15 16:18:27 UTC 
Review of attachment 294590 [details] [review]:

::: validate/launcher/baseclasses.py
@@ -276,3 @@
         self.time_taken = time.time() - self._starting_time
 
-        if not self.reporter.uses_standard_output():

Ah, ok
Comment 5 Ramiro Polla 2015-01-16 15:14:18 UTC 
Created attachment 294693 [details] [review]
validate: launcher: Fix test log header output

Updated to apply cleanly after patches from #742973
Comment 6 Thibault Saunier 2015-01-16 16:18:45 UTC 
Attachment 294693 [details] pushed as b29f378 - validate: launcher: Fix test log header output