After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742965 - validate: launcher: Don't wait for processes longer than necessary
validate: launcher: Don't wait for processes longer than necessary
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-15 12:13 UTC by Ramiro Polla
Modified: 2015-02-17 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
launcher: Don't wait for processes longer than necessary (3.17 KB, patch)
2015-01-15 12:15 UTC, Ramiro Polla
accepted-commit_now Details | Review
launcher: Don't wait for processes longer than necessary (3.15 KB, patch)
2015-01-16 15:15 UTC, Ramiro Polla
none Details | Review

Description Ramiro Polla 2015-01-15 12:13:36 UTC
Currently gst-validate-launcher will remain idle for up to one second every time a test process ends. The attached patch uses thread joining to remove this idle wait.
Comment 1 Ramiro Polla 2015-01-15 12:15:32 UTC
Created attachment 294589 [details] [review]
launcher: Don't wait for processes longer than necessary
Comment 2 Thibault Saunier 2015-01-15 14:35:59 UTC
Review of attachment 294589 [details] [review]:

OK
Comment 3 Ramiro Polla 2015-01-16 15:15:20 UTC
Created attachment 294694 [details] [review]
launcher: Don't wait for processes longer than necessary

Updated to apply cleanly after patch from #742966
Comment 4 Thibault Saunier 2015-02-17 16:24:39 UTC
commit bdedd7abb9a8d1fdf241bf636e075ddf0f761b85
Author: Ramiro Polla <ramiro.polla@collabora.co.uk>
Date:   Mon Jan 12 13:09:33 2015 +0100

    validate: launcher: Don't wait for processes longer than necessary