After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742947 - Bad startup app icons sizes
Bad startup app icons sizes
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-15 01:42 UTC by Marek Černocký
Modified: 2015-08-18 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot with startup app icons (113.35 KB, image/png)
2015-01-15 01:42 UTC, Marek Černocký
  Details
Proposed patch to fix the icon size (1.43 KB, patch)
2015-01-18 17:04 UTC, Gian Mario Tagliaretti
none Details | Review
screenshot with gnome 3.16 (30.37 KB, image/png)
2015-05-25 11:40 UTC, Marius Gedminas
  Details
startup: Force a pixel icon size (1.88 KB, patch)
2015-08-18 14:53 UTC, Rui Matos
committed Details | Review

Description Marek Černocký 2015-01-15 01:42:55 UTC
Created attachment 294565 [details]
Screenshot with startup app icons

Some icons in the startup applications list has a reasonless size. See attached screenshot.
Comment 1 Gian Mario Tagliaretti 2015-01-18 09:06:23 UTC
This should be due a change in GTK+ 3.14, from the release note:

* The icon theme code has become a little pickier about sizes and is not
  automatically scaling icons beyond the limits defined in the icon theme
  unless explicitly asked to do so with GTK_ICON_LOOKUP_FORCE_SIZE.

https://git.gnome.org/browse/gtk+/tree/README.in#n111
Comment 2 Gian Mario Tagliaretti 2015-01-18 17:04:44 UTC
Created attachment 294804 [details] [review]
Proposed patch to fix the icon size

Proposed patch to fix the icon size
Comment 3 Marek Černocký 2015-01-18 21:53:29 UTC
It isn't enough. The same problem has list with added applications. (class _StartupTweak in the same file)

And question: Is it correct to use numeric value 48? Should not this be some constant? What it will do for hires displays and like?
Comment 4 Gian Mario Tagliaretti 2015-01-19 06:40:03 UTC
(In reply to comment #3)

Hi Marek,

> It isn't enough. The same problem has list with added applications. (class
> _StartupTweak in the same file)

I agree that is not definitive, it's a first attempt (I meant to write that in the comment itself but I've sent it too quickly)

> And question: Is it correct to use numeric value 48? Should not this be some
> constant? What it will do for hires displays and like?

I had the same concern, I've been trying with Gtk.IconSize.DIALOG but it results in super-tiny icons to be displayed.

Any suggestion/comment is welcome as usual.
Comment 5 Rui Matos 2015-02-14 23:34:47 UTC
I think this issue has been addressed in gtk+, do we still need this?
Comment 6 Marius Gedminas 2015-05-25 11:40:15 UTC
Created attachment 303914 [details]
screenshot with gnome 3.16

I'm still seeing irregular icon sizes in GNOME 3.16.
Comment 7 Rui Matos 2015-08-18 14:53:28 UTC
Created attachment 309480 [details] [review]
startup: Force a pixel icon size

If we don't set a pixel size gtk+ doesn't scale the resulting pixbuf
unless the source icon is in a scalable format such as SVG.
Comment 8 Rui Matos 2015-08-18 14:54:00 UTC
Attachment 309480 [details] pushed as 696b127 - startup: Force a pixel icon size