After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742916 - basesink: Fix QoS handling if the subclass has a prepare/prepare_list implementation
basesink: Fix QoS handling if the subclass has a prepare/prepare_list impleme...
Status: RESOLVED DUPLICATE of bug 749258
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-14 13:22 UTC by Sebastian Dröge (slomo)
Modified: 2015-05-13 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basesink: Fix QoS handling if the subclass has a prepare/prepare_list implementation (6.06 KB, patch)
2015-01-14 13:23 UTC, Sebastian Dröge (slomo) 		none Details | Review

Description Sebastian Dröge (slomo) 2015-01-14 13:22:59 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2015-01-14 13:23:01 UTC 
Created attachment 294521 [details] [review]
basesink: Fix QoS handling if the subclass has a prepare/prepare_list implementation

We have to calculate the difference against the current clock running time
instead of just using 0 as jitter, and also have to update some internal
variables. Which in the end means that we can just reuse most of do_sync().
Comment 2 Sebastian Dröge (slomo) 2015-01-14 13:44:59 UTC 
One problem here is that this also already updates the position before prepare() is called, while that should really only happen before render(). The syncing logic is storing too many things in the instance struct instead of passing it around as parameters to the different functions and setting it once.
Comment 3 Sebastian Dröge (slomo) 2015-05-13 10:56:19 UTC 
Bug #749258 solves this and has a better patch.

*** This bug has been marked as a duplicate of bug 749258 ***