After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742903 - Add missing (transfer) annotation to GString
Add missing (transfer) annotation to GString
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-01-14 10:51 UTC by Philip Withnall
Modified: 2015-09-02 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstring: Mark g_string_free() as taking (transfer full) input (837 bytes, patch)
2015-01-14 10:51 UTC, Philip Withnall
none Details | Review
gactiongroup: Fix incorrect (transfer) annotations (1.04 KB, patch)
2015-01-14 10:51 UTC, Philip Withnall
none Details | Review
gstring: Mark g_string_free() as taking (transfer full) input (837 bytes, patch)
2015-09-02 08:08 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2015-01-14 10:51:43 UTC
A couple of trivial patches to add missing (transfer) annotations.
Comment 1 Philip Withnall 2015-01-14 10:51:45 UTC
Created attachment 294504 [details] [review]
gstring: Mark g_string_free() as taking (transfer full) input

This is unusual, but the correct annotation for a free() function.
Comment 2 Philip Withnall 2015-01-14 10:51:51 UTC
Created attachment 294505 [details] [review]
gactiongroup: Fix incorrect (transfer) annotations

g_action_group_get_action_state_type() is const, and definitely does not
return ownership of the GVariantType. Same for
g_action_group_get_action_parameter_type().
Comment 3 Philip Withnall 2015-09-02 08:06:34 UTC
Comment on attachment 294505 [details] [review]
gactiongroup: Fix incorrect (transfer) annotations

Fixed already by bug #730168.
Comment 4 Philip Withnall 2015-09-02 08:08:51 UTC
Created attachment 310465 [details] [review]
gstring: Mark g_string_free() as taking (transfer full) input

This is unusual, but the correct annotation for a free() function.
Comment 5 Colin Walters 2015-09-02 12:12:19 UTC
Review of attachment 310465 [details] [review]:

Yep.
Comment 6 Philip Withnall 2015-09-02 13:52:29 UTC
Thanks for the review.

Attachment 310465 [details] pushed as b77fe97 - gstring: Mark g_string_free() as taking (transfer full) input