After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742902 - Python exception color scheme is suboptimal
Python exception color scheme is suboptimal
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-14 10:21 UTC by Elad Alfassa
Modified: 2015-01-20 03:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
style: improve Builder style scheme for Python (1.54 KB, patch)
2015-01-20 03:46 UTC, Christian Hergert
committed Details | Review

Description Elad Alfassa 2015-01-14 10:21:37 UTC
When using the default Builder color scheme and writing python code, Builder uses the same shade of green for `except` (the keyword) and (for example) `KeyError` (the exception name). This is a bit subpoptimal in my opinion, and most other color schemes and text editors I've used color these differently.

Can this be changed?
Comment 1 Christian Hergert 2015-01-14 10:52:27 UTC
If it is different in Gedit, then it can be changed.

Some things, though, need to be fixed in the language specifications. A bunch of style elements will ultimately reference the same color (sometimes). I know it was sort of an issue for C with a few things I wanted.
Comment 2 Elad Alfassa 2015-01-14 11:10:50 UTC
gedit colors the word `except` in red, and the exception name in green if it's a built-in exception (and not a custom exception), so yes, it's different.

I don't have any recommendation / idea to what colors Builder should use in this case tho.
Comment 3 Christian Hergert 2015-01-20 03:46:54 UTC
Created attachment 294940 [details] [review]
style: improve Builder style scheme for Python

We are going to have to do a lot of custom tweaks like this per language
I presume. Still lot's to do, but this is a start.
Comment 4 Christian Hergert 2015-01-20 03:47:29 UTC
Attachment 294940 [details] pushed as 45a9ddc - style: improve Builder style scheme for Python