GNOME Bugzilla – Bug 742890
Selecting a theme is too difficult
Last modified: 2015-01-15 04:14:25 UTC
Created attachment 294489 [details] is this a bug? I'm not sure about the user experience of the theme selector. I think this would be good to run past a designer. It looks MOSTLY good, but when arriving at the dialog for the first time, it's not very clear how to select a theme. We really need something for users to click on to close the dialog (the only way out I've found is to press Escape) and it's a bit confusing/trippy that you can actually play a mini game from the preferences dialog (so much so that I'm not entirely sure if that is not a bug? :)
Playing the mini-game from the dialog is not a bug, I have added that intentionally, as there are some button states which can only be tested in a "live preview": e.g. hover states can not be seen on an inactive theme preview, a real minefield can not have overmine warnings and questions and mines and exploded mine at once. About the closeability: I agree, a close button would be nice, and as this being an instant-apply preferences dialog, the HIG recommends an in-headerbar close button.
How come you don't have the left/right buttons (is this from current master)? There should be one button on each side (partially overlapping the preview, like carousel change buttons)
Created attachment 294492 [details] [review] theme-selector: use headerbar and close button
Comment on attachment 294492 [details] [review] theme-selector: use headerbar and close button Attachment 294492 [details] pushed as 3a7e0f8 - theme-selector: use headerbar and close button
Added close button in headerbar. Should I leave this open for design feedback on theme selection, or was the problem the lack of a close button after selecting the theme?
(In reply to comment #2) > How come you don't have the left/right buttons (is this from current master)? Yeah, it's master of everything. The dialog feels much, much better with the header bar. I dunno why the left/right buttons weren't present for that video; I have them today. You might experiment with moving the left/right buttons to the header bar, though; I wonder if that would work better or not. I wouldn't change anything else. I think users will like this now. :)
Created attachment 294545 [details] [review] Capitalize title of theme selector dialog
Comment on attachment 294545 [details] [review] Capitalize title of theme selector dialog Attachment 294545 [details] pushed as 8670a0d - Capitalize title of theme selector dialog
Created attachment 294566 [details] [review] theme-selector: theme switching button placing fixes * in case of headerbar-using desktop shells use the headerbar to show the previous/next buttons * in case of unity add the theme switcher buttons to the dialog content area * in case of unity add a close button to the action area as we don't have a headerbar with a close button
That looks good. I would link the buttons, though.
How can I do that? I see a GTK_STYLE_CLASS_LINKED style class used for e.g. stackswitcher, which I know having linked buttons, but adding this class for the buttons did not link them.
Ok, finally found out that I have to add that class to the container of the buttons, so pushed the patch and in another commit added the theme switcher buttons as linked. Thanks for the much appreciated feedback. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.