After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742771 - [PATCH] Properly ignore BadWindow and BadDrawable in get_child_info_handler()
[PATCH] Properly ignore BadWindow and BadDrawable in get_child_info_handler()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-01-11 18:40 UTC by maksqwe
Modified: 2015-01-11 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (817 bytes, patch)
2015-01-11 18:40 UTC, maksqwe 		committed Details | Review

Description maksqwe 2015-01-11 18:40:25 UTC 
Created attachment 294297 [details] [review]
Patch

gdkasync.c 479

  if (rep->generic.type == X_Error)
    {
      state->child_has_error = TRUE;
      if (rep->error.errorCode != BadDrawable ||  < ----
	  rep->error.errorCode != BadWindow)
	{
	  state->have_error = TRUE;
	  result = False;
	}
    }


This condition is always true. I Think should be 
if (rep->error.errorCode != BadDrawable &&
    rep->error.errorCode != BadWindow)