GNOME Bugzilla – Bug 742762
Closing the promotion dialog switches move to the other player without the current player moving
Last modified: 2015-01-11 18:26:09 UTC
Steps to reproduce: ---------------------------- 1. Start a new game. 2. Move (white)pawn to do a promotion. 3. Close the promotion dialog without choosing any piece for promotion. 4. Other player(black) gets to move and (white)pawn is still in old position. We should either: 1. Disable closing the promotion dialog. or 2. Assume that, because the player closed the promotion dialog, he wants to do a different move( not a promotion ) and allow him to do a different move. [Basically don't switch players - Allow the current player to move]
If the dialog is destroyed prematurely, it's supposed to move the pawn and promote to a Queen, which is what happens when I test this. But prohibiting deletion would be good indeed.
Actually, I think I'd prefer deleting the dialog to just cancel the move. Doesn't much matter either way, but canceling the move would be easier.
Created attachment 294288 [details] [review] Cancel move if promotion type selector is closed
Created attachment 294289 [details] [review] Prohibit deletion of promotion type dialog This is hacky, but I can't figure out how else to handle the Escape key. Probably allowing the user to cancel the dialog is better anyway.
I was inclined to solution 2 as well. Pushed "Cancel move if promotion type selector is closed" to master. Thanks :D