After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742687 - DevHelpBookTree is wider when searching
DevHelpBookTree is wider when searching
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-10 08:47 UTC by Trinh Anh Ngoc
Modified: 2015-02-16 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (38.19 KB, image/png)
2015-01-10 08:47 UTC, Trinh Anh Ngoc 		  Details
Adjust book tree margins (1.21 KB, patch)
2015-01-10 08:48 UTC, Trinh Anh Ngoc 		none Details | Review
screenshot (281.54 KB, image/png)
2015-01-27 10:39 UTC, Allan Day 		  Details
Refine sidebar ui (2.14 KB, patch)
2015-01-27 15:27 UTC, Trinh Anh Ngoc 		none Details | Review
Screenshot (66.34 KB, image/png)
2015-01-27 15:28 UTC, Trinh Anh Ngoc 		  Details

Description Trinh Anh Ngoc 2015-01-10 08:47:41 UTC 
Created attachment 294205 [details]
Screenshot

Look screenshot
Comment 1 Trinh Anh Ngoc 2015-01-10 08:48:49 UTC 
Created attachment 294206 [details] [review]
Adjust book tree margins
Comment 2 Allan Day 2015-01-27 10:39:15 UTC 
Created attachment 295514 [details]
screenshot

The change looks like an improvement, from a design point of view.

If you wanted to improve it even further, my suggestion would be to remove the border and padding around the list (by setting shadow-type on the documentation list to GTK_SHADOW_NONE, and border-width to 0), since the border isn't necessary and adds visual noise.

Also, the padding around the search box is a bit low - setting the margin to 6px would help.

I've attached a screenshot of 3.14 with these changes.
Comment 3 Trinh Anh Ngoc 2015-01-27 15:27:58 UTC 
Created attachment 295546 [details] [review]
Refine sidebar ui

Thanks Allan.
Comment 4 Trinh Anh Ngoc 2015-01-27 15:28:43 UTC 
Created attachment 295547 [details]
Screenshot
Comment 5 Frederic Peters 2015-02-16 08:13:15 UTC 
Thanks!

Attachment 295546 [details] pushed as 6a4c11d - Refine sidebar ui