After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742675 - [PATCH] core: ensure manager state is updated on resume with connectivity checking enabled
[PATCH] core: ensure manager state is updated on resume with connectivity che...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 741687 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-09 21:59 UTC by Dan Williams
Modified: 2015-02-25 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-core-ensure-manager-state-is-updated-on-resume-with-.patch (1.75 KB, patch)
2015-01-09 22:00 UTC, Dan Williams 		none Details | Review

Description Dan Williams 2015-01-09 21:59:27 UTC 
On resume configured interfaces are unmanaged to clear their pre-resume
state and then re-managed.  Eventually the interface should end up moving
to the DISCONNECTED state, which should trigger an auto-activate check in
the Policy.  If connectivity checking was enabled, that auto-activate check
would fail because the Manager's state was still NM_STATE_ASLEEP.

This caused bridge slaves not to auto-activate on resume, which left bridges
without connectivity.

The manager never left NM_STATE_ASLEEP when connectivity checking was
enabled due to nm_manager_update_state() returning early when kicking
off a connectivity check.  Instead, the manager's state should always
be updated to accurately reflect the current state.
Comment 1 Dan Williams 2015-01-09 22:00:40 UTC 
Created attachment 294187 [details] [review]
0001-core-ensure-manager-state-is-updated-on-resume-with-.patch
Comment 2 Dan Winship 2015-01-10 15:55:44 UTC 
Comment on attachment 294187 [details] [review]
0001-core-ensure-manager-state-is-updated-on-resume-with-.patch

so I'm the one who suggested this approach, so I don't know if my review counts, but looks good to me! :)
Comment 3 Thomas Haller 2015-01-11 21:33:11 UTC 
LGTM too (didn't test it)
Comment 4 Dan Williams 2015-01-12 15:57:28 UTC 
*** Bug 741687 has been marked as a duplicate of this bug. ***
Comment 5 Dan Williams 2015-01-12 17:54:49 UTC 
master: a687d1f9e0f75b987f40335934b54aa748f6724b
nm-1-0: cd26f835f4dd2286bd73fed3e7236d17ea147920
nm-0-9-10: a5a7e5cbaaa36d6e1f346e5349a15d8b3a36e10a