After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742652 - Easy to confuse disk/partition "restore disk image"
Easy to confuse disk/partition "restore disk image"
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-09 15:03 UTC by Bastien Nocera
Modified: 2015-02-03 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix halign of hamburger menu (889 bytes, patch)
2015-01-10 19:52 UTC, Michael Catanzaro
committed Details | Review
Disambiguate menu items to reduce confusion (3.00 KB, patch)
2015-01-10 19:52 UTC, Michael Catanzaro
committed Details | Review

Description Bastien Nocera 2015-01-09 15:03:34 UTC
I hit this problem today trying to create bootable USB drives from an ISO image. The disk already had a partition on it, and I created unbootable drives by wrongly selecting the partition's "restore disk image" instead of the disk's one.

I'm not sure how to fix this without removing the "restore disk image" menu item from the partition's menu.
Comment 1 Michael Catanzaro 2015-01-09 16:28:50 UTC
(In reply to comment #0)
> I'm not sure how to fix this without removing the "restore disk image" menu
> item from the partition's menu.

I'd rather not remove this functionality. I think the problem is more general: the UI only works once you understand that actions that affect the disk are in the hamburger menu, actions that affect a particular partition are in the menu underneath the disk layout, and the selected (highlighted) partition is the one that's going to be affected by the partition-specific action.

A mitigation would be to add the work Disk after everything that's ambiguous in the hamburger menu, and the word Partition after everything that's ambiguous in the partition menu. Something like this:

Hamburger Menu:

Format Disk...
Create Disk Image...
Restore Disk Image... (or Write Disk Image...)
Benchmark Disk...
SMART Data & Self-Tests...
Drive Settings...
Standby Now

Partition Menu:

Format Partition...
Edit Partition...
Edit Filesystem...
Change Passphrase...
Edit Mount Options...
Edit Encryption Options...
Create Partition Image... (or Create Image from Partition...)
Restore Image to Partition... (or Write Image to Partition..., or Write Partition Image...)
Benchmark Partition...
Comment 2 Bastien Nocera 2015-01-09 17:55:23 UTC
That sounds like a good mitigation to me.
Comment 3 Michael Catanzaro 2015-01-10 19:52:25 UTC
Created attachment 294240 [details] [review]
Fix halign of hamburger menu
Comment 4 Michael Catanzaro 2015-01-10 19:52:28 UTC
Created attachment 294241 [details] [review]
Disambiguate menu items to reduce confusion
Comment 5 Michael Catanzaro 2015-02-03 19:58:10 UTC
Attachment 294240 [details] pushed as 5869754 - Fix halign of hamburger menu
Attachment 294241 [details] pushed as 8bc84da - Disambiguate menu items to reduce confusion