After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742592 - snippets/python: add some basic templates
snippets/python: add some basic templates
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-08 14:52 UTC by Igor Gnatenko
Modified: 2015-01-09 06:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
snippets/python: add some basic templates (1.20 KB, patch)
2015-01-08 14:52 UTC, Igor Gnatenko
reviewed Details | Review
snippets/python: add some basic templates (1.19 KB, patch)
2015-01-09 06:30 UTC, Igor Gnatenko
committed Details | Review

Description Igor Gnatenko 2015-01-08 14:52:03 UTC
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 1 Igor Gnatenko 2015-01-08 14:52:06 UTC
Created attachment 294091 [details] [review]
snippets/python: add some basic templates
Comment 2 Christian Hergert 2015-01-08 22:17:44 UTC
Review of attachment 294091 [details] [review]:

Couple nits, and then looks good. Go ahead and change those and just push.

::: src/resources/snippets/python.snippets
@@ -35,2 +38,4 @@
 	# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 	$0
+snippet import
+	import ${1}

I think we can just do "import $0" here. Hitting enter is as easy as Tab to move to next line. (You also don't break out of snippet mode until reaching $0, so it could get annoying).

@@ -37,0 +40,5 @@
+snippet import
+	import ${1}
+	$0
... 2 more ...

Same here. "from ${1} import $0"
Comment 3 Igor Gnatenko 2015-01-09 06:30:27 UTC
Created attachment 294139 [details] [review]
snippets/python: add some basic templates

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=742592
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 4 Igor Gnatenko 2015-01-09 06:30:56 UTC
Attachment 294139 [details] pushed as 367b6f4 - snippets/python: add some basic templates