After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742591 - snippets: add rpmspec snippets (skeletons)
snippets: add rpmspec snippets (skeletons)
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-08 14:50 UTC by Igor Gnatenko
Modified: 2015-01-09 06:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
snippets: add rpmspec snippets (skeletons) (5.39 KB, patch)
2015-01-08 14:50 UTC, Igor Gnatenko 		reviewed Details | Review
snippets: add rpmspec snippets (skeletons) (5.48 KB, patch)
2015-01-09 06:26 UTC, Igor Gnatenko 		committed Details | Review

Description Igor Gnatenko 2015-01-08 14:50:42 UTC 
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 1 Igor Gnatenko 2015-01-08 14:50:50 UTC 
Created attachment 294090 [details] [review]
snippets: add rpmspec snippets (skeletons)
Comment 2 Christian Hergert 2015-01-08 22:20:18 UTC 
Review of attachment 294090 [details] [review]:

Couple nits, then looks good to push.

::: src/resources/snippets/rpmspec.snippets
@@ +32,3 @@
+	* $shortweekday $shortmonth $day $year ${13:$fullname} <${14:$email}> - $2-$3
+	- Initial package$0
+snippet lib

I think it's okay to make this "library". You don't have to type the whole snippet name to expand it.

@@ +84,3 @@
+	* $shortweekday $shortmonth $day $year ${18:$fullname} <${19:$email}> - $2-$3
+	- Initial package$0
+snippet pyhton-arch

Spelling, python-arch
Comment 3 Igor Gnatenko 2015-01-09 06:26:45 UTC 
Created attachment 294137 [details] [review]
snippets: add rpmspec snippets (skeletons)

v2:
    fix typo in python-arch snippet name
    rename lib to library snippet

Reference: https://bugzilla.gnome.org/show_bug.cgi?id=742591
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 4 Igor Gnatenko 2015-01-09 06:27:28 UTC 
Attachment 294137 [details] pushed as f2e4fca - snippets: add rpmspec snippets (skeletons)