After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742545 - append() takes exactly one argument (2 given)
append() takes exactly one argument (2 given)
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-01-07 18:55 UTC by Thiago F. G. Albuquerque
Modified: 2015-01-08 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Append takes exactly one argument (1.11 KB, patch)
2015-01-07 20:43 UTC, Marcus Karlsson
none Details | Review

Description Thiago F. G. Albuquerque 2015-01-07 18:55:14 UTC
$ jhbuild sysdeps --install vte

W: Circular dependencies detected: vte -> glib -> gvfs -> glib
W: Circular dependencies detected: vte -> glib -> glib-networking -> glib
W: Circular dependencies detected: vte -> glib -> dconf -> glib
W: Circular dependencies detected: vte -> gtk+ -> adwaita-icon-theme -> gtk+
System installed packages which are new enough:
    flex (required=2.0)
    freetype2 (freetype2.pc, required=2.4.9, installed=14.0.8)
    git 
    make 
    intltool (required=0.50)
    libXft (xft.pc, required=2.0.0, installed=2.2.0)
    libpng (libpng.pc, installed=1.2.46)
    xorg-xproto (xproto.pc, installed=7.0.22)
    docbook-xsl 
    xmllint 
    xorg-kbproto (kbproto.pc, installed=1.0.5)
    libffi (libffi.pc, required=3.0.0, installed=3.0.11-rc1)
    gettext-bin 
    bison (required=2.4)
    pixman (pixman-1.pc, required=0.30, installed=0.30.2)
    libxml2 (libxml-2.0.pc, required=2.7.8, installed=2.7.8)
    gl (gl.pc, installed=8.0.4)
    pkg-config 
    libxml2-python 
    c++ 
    libX11 (x11.pc, installed=1.4.99.1)
    libtool 
    shared-mime-info (shared-mime-info.pc, required=1.0, installed=1.0)
    cc 
    xsltproc 
    zlib (zlib.pc, installed=1.2.3.4)
    automake 
    xmlcatalog 
Required packages:
  System installed packages which are too old:
    xcb (xcb.pc, required=1.10, installed=1.8.1)
  No matching system package installed:
    dbus (dbus-1.pc, required=1.4.10)
    libtiff 
    python2-devel (python2.pc, required=2.5)
    xorg-macros (xorg-macros.pc)
    doxygen (required=1.8.1)
    egl (egl.pc, required=10.1.3)
    libXtst (xtst.pc, required=1)
    libxslt (libxslt.pc, required=1.1.26)
    xmlto 
    libicu (icu-i18n.pc, required=4)
    xcb-xkb (xcb-xkb.pc, required=1.10)
    ragel 
    libjpeg 
Optional packages: (JHBuild will build the missing packages)
  System installed packages which are too old:
    xtrans (xtrans.pc, required=1.3.5, installed=1.2.6)
    fontconfig (fontconfig.pc, required=2.11.1, installed=2.8.0)
  No matching system package installed:
I: Installing dependencies on system: dbus libtiff python2-devel xorg-macros doxygen egl libXtst libxslt xmlto libicu xcb-xkb ragel libjpeg
Traceback (most recent call last):
  • File "/home/tfga/bin/jhbuild", line 32 in <module>
    jhbuild.main.main(sys.argv[1:])
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/main.py", line 151 in main
    rc = jhbuild.commands.run(command, config, args, help=lambda: print_help(parser))
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/__init__.py", line 183 in run
    return cmd.execute(config, args, help)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/__init__.py", line 52 in execute
    return self.run(config, options, args, help)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/sysdeps.py", line 207 in run
    installer.install(uninstalled)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/utils/systeminstall.py", line 364 in install
    uninstalled_pkgconfigs, uninstalled_filenames = get_uninstalled_pkgconfigs_and_filenames(uninstalled)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/utils/systeminstall.py", line 62 in get_uninstalled_pkgconfigs_and_filenames
    uninstalled_pkgconfigs.append(module_name, value)
TypeError: append() takes exactly one argument (2 given)

Comment 1 Frederic Peters 2015-01-07 20:42:39 UTC
Sorry about that.

commit 9b3a58783464fc9ac159da14e2bf53ef1915f2b0
Author: Frédéric Péters <fpeters@0d.be>
Date:   Wed Jan 7 21:41:51 2015 +0100

    add missing parenthesises
    
    https://bugzilla.gnome.org/show_bug.cgi?id=742545
Comment 2 Marcus Karlsson 2015-01-07 20:43:55 UTC
Created attachment 294061 [details] [review]
Append takes exactly one argument

I'm running into this problem as well. It looks like one of the calls to append in get_uninstalled_pkgconfigs_and_filenames passes two arguments instead of one to append. By looking at the other appends in that function I assume that they should be passed as a tuple, which solved the problem for me.
Comment 3 Marcus Karlsson 2015-01-07 20:46:10 UTC
Comment on attachment 294061 [details] [review]
Append takes exactly one argument

Resolved while submitting.
Comment 4 Thiago F. G. Albuquerque 2015-01-07 21:06:13 UTC
I did a 'git pull', but now the error is this:

Traceback (most recent call last):
  • File "/home/tfga/bin/jhbuild", line 32 in <module>
    jhbuild.main.main(sys.argv[1:])
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/main.py", line 151 in main
    rc = jhbuild.commands.run(command, config, args, help=lambda: print_help(parser))
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/__init__.py", line 183 in run
    return cmd.execute(config, args, help)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/__init__.py", line 52 in execute
    return self.run(config, options, args, help)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/commands/sysdeps.py", line 207 in run
    installer.install(uninstalled)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/utils/systeminstall.py", line 364 in install
    uninstalled_pkgconfigs, uninstalled_filenames = get_uninstalled_pkgconfigs_and_filenames(uninstalled)
  • File "/home/tfga/jhbuild/checkout/jhbuild/jhbuild/utils/systeminstall.py", line 66 in get_uninstalled_pkgconfigs_and_filenames
    uninstalled_filenames.append((module.name, os.path.join('/usr/include', value),))
NameError: global name 'module' is not defined

Someone changed the source, but not quite in the way that was suggested...
Comment 5 Thiago F. G. Albuquerque 2015-01-07 21:17:50 UTC
(In reply to comment #4)

Sorry, this is a different error. My mistake.

I replaced 'module.name' => 'module_name' and it solved the problem.
Comment 6 Frederic Peters 2015-01-08 08:05:14 UTC
Indeed that should habe been module_name; I pushed the fix.