After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742522 - Improve list layout
Improve list layout
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Notifications
git master
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-07 12:36 UTC by Allan Day
Modified: 2015-01-20 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Shrink application icons (3.48 KB, patch)
2015-01-16 11:51 UTC, Marek Kašík 		committed Details | Review
screenshot of the result (30.97 KB, image/png)
2015-01-16 11:51 UTC, Marek Kašík 		  Details

Description Allan Day 2015-01-07 12:36:15 UTC 
The layout of the list of apps could be improved - there isn't enough padding around the icons, or after the status text on the right. Using a smaller application icon could help here.

See: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/notifications/notifications-wireframes.png
Comment 1 Marek Kašík 2015-01-16 11:51:08 UTC 
Created attachment 294681 [details] [review]
Shrink application icons

This patch shrinks applications icons and add some margins so that the overall size of the row is the same.

You need to have the patches from the bugs #742520 and #742521 applied before this one.
Comment 2 Marek Kašík 2015-01-16 11:51:44 UTC 
Created attachment 294682 [details]
screenshot of the result
Comment 3 Rui Matos 2015-01-16 16:40:58 UTC 
Review of attachment 294681 [details] [review]:

The changes in notifications.ui could be in one of the other patches but it's ok
Comment 4 Marek Kašík 2015-01-20 14:20:52 UTC 
Comment on attachment 294681 [details] [review]
Shrink application icons

Thank you for the review. I've pushed it to master.