After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742503 - Add V4L2 support for OpenBSD
Add V4L2 support for OpenBSD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.5
Other OpenBSD
: Normal enhancement
: 1.4.6
Assigned To: Brad Smith
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-07 02:50 UTC by Brad Smith
Modified: 2015-01-08 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
autoconf patch (585 bytes, patch)
2015-01-07 02:50 UTC, Brad Smith 		reviewed Details | Review
Git formatted patch for the autoconf script (985 bytes, patch)
2015-01-08 02:55 UTC, Brad Smith 		committed Details | Review

Description Brad Smith 2015-01-07 02:50:21 UTC 
Created attachment 293996 [details] [review]
autoconf patch

The attached patch adds support for OpenBSD's V4L2 layer which uses the header sys/videoio.h.
Comment 1 Nicolas Dufresne (ndufresne) 2015-01-07 16:08:55 UTC 
Review of attachment 293996 [details] [review]:

This change makes sense to me. Note that the header itself is not used any-more (unless if using libv4l2), it's only there to make sure we don't try ans build v4l2 element on OS like Windows or OSX. Would it be possible to resubmit this patch using proper form ? This basically mean

git clone git://anongit.freedesktop.org/gstreamer/gst-plugins-good
git checkout 1.4

... Make you changes ...

git add configure.ac
git commit

The commit message should in the the format:
"""
v4l2: Short description

Longer description (if needed)

https://bugzilla.gnome.org/review?bug=742503
"""

I'm asking this because it makes my work easier and ensure your name is on it.
Comment 2 Nicolas Dufresne (ndufresne) 2015-01-07 16:10:36 UTC 
Oh, and to get the change into a patch file,

git format-patch -1
Comment 3 Brad Smith 2015-01-08 02:43:27 UTC 
Yes, I was aware of the fact that the header was not used anymore. I was re-creating the patch from scratch as we had patches in the past but had to drop the GStreamer support due to an implementation bug in the V4L2 layer which was recently fixed. I was delighted to see the whole situation was much simpler with newer GStreamer releases. Went looking in the ChangeLog and noticed the V4L2 header was imported right into GStreamer.

I only posted the patch as is since I noticed other bug reports more or less doing the same thing and the patches were commited.

Give me a bit and I will roll a patch as you have requested.
Comment 4 Brad Smith 2015-01-08 02:55:43 UTC 
Created attachment 294071 [details] [review]
Git formatted patch for the autoconf script
Comment 5 Nicolas Dufresne (ndufresne) 2015-01-08 13:56:07 UTC 
Review of attachment 294071 [details] [review]:

Thank you, I'm merging it now.
Comment 6 Nicolas Dufresne (ndufresne) 2015-01-08 14:36:24 UTC 
Comment on attachment 294071 [details] [review]
Git formatted patch for the autoconf script

Master
133bad7 v4l2: Add support for detecting the presence of V4L2 support on OpenBS

1.4
50f05a4 v4l2: Add support for detecting the presence of V4L2 support on OpenBSD