After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742481 - OSX Bootstrap improvements
OSX Bootstrap improvements
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-01-06 20:22 UTC by Patrick Griffis (tingping)
Modified: 2015-01-06 22:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add cmake to osx bootstrap (1.80 KB, patch)
2015-01-06 20:23 UTC, Patrick Griffis (tingping) 		needs-work Details | Review
Bump bison requirement (783 bytes, patch)
2015-01-06 20:23 UTC, Patrick Griffis (tingping) 		needs-work Details | Review
Add bison to osx bootstrap (1.24 KB, patch)
2015-01-06 20:24 UTC, Patrick Griffis (tingping) 		needs-work Details | Review
Update libxml2 on osx (1.34 KB, patch)
2015-01-06 20:25 UTC, Patrick Griffis (tingping) 		needs-work Details | Review
Update libxml2 on osx (1.02 KB, patch)
2015-01-06 21:54 UTC, Patrick Griffis (tingping) 		committed Details | Review
Bump required bison version to 2.4 (1.76 KB, patch)
2015-01-06 21:58 UTC, Patrick Griffis (tingping) 		committed Details | Review
Add cmake to osx bootstrap (1.79 KB, patch)
2015-01-06 21:59 UTC, Patrick Griffis (tingping) 		committed Details | Review

Description Patrick Griffis (tingping) 2015-01-06 20:22:48 UTC 
- Updates libxml2 on osx to 2.9.2 for a python
- Bump required bison version to 2.4 for gstreamer
- Adds bison to osx for previous version requirement
- Adds cmake to osx
Comment 1 Patrick Griffis (tingping) 2015-01-06 20:23:27 UTC 
Created attachment 293970 [details] [review]
Add cmake to osx bootstrap
Comment 2 Patrick Griffis (tingping) 2015-01-06 20:23:52 UTC 
Created attachment 293971 [details] [review]
Bump bison requirement
Comment 3 Patrick Griffis (tingping) 2015-01-06 20:24:18 UTC 
Created attachment 293972 [details] [review]
Add bison to osx bootstrap
Comment 4 Patrick Griffis (tingping) 2015-01-06 20:25:02 UTC 
Created attachment 293973 [details] [review]
Update libxml2 on osx
Comment 5 Allison Karlitskaya (desrt) 2015-01-06 21:20:27 UTC 
Review of attachment 293973 [details] [review]:

::: modulesets/bootstrap.modules
@@ +121,3 @@
   </autotools>
 
+  <autotools id="libxml2" autogen-template="%(srcdir)s/configure --prefix=%(prefix)s --with-python-install-dir=%(prefix)s/lib/python2.7/site-packages">

Please drop the autogen-template change here since this is unrelated.
Comment 6 Allison Karlitskaya (desrt) 2015-01-06 21:21:21 UTC 
Review of attachment 293970 [details] [review]:

::: modulesets/bootstrap.modules
@@ +91,3 @@
+            module="v3.1/cmake-3.1.0.tar.gz" version="3.1.0"
+            size="5955836"
+            hash="sha256:8bdc3fa3f2da81bc10c772a6b64cc9052acc2901d42e1e1b2588b40df224aad9">

better to write <branch/> if possible instead of having it as two separate tags
Comment 7 Allison Karlitskaya (desrt) 2015-01-06 21:26:30 UTC 
Review of attachment 293972 [details] [review]:

If I were splitting the bison patches up, I'd have gone with the changes to the main modulesets (ie: add the dependency to gstreamer and bump the version number) together and the bootstrap change separately.

I don't think it really matters that much, though, so I'd just roll all three changes into a single patch.

It's worth noting that we can't actually detect version numbers on path: type sysdeps, but that's OK -- the information could still be useful for humans who want to read it.

::: modulesets/bootstrap.modules
@@ +40,3 @@
+            size="3261770"
+            hash="sha256:cdf29d1a4c0f7d5b0c181bc8818fe6816d3b6ad4fcc8f6c0e5540a228c3f81ed">
+    </branch>

Ditto about <branch></branch> vs. <branch/>
Comment 8 Allison Karlitskaya (desrt) 2015-01-06 21:28:47 UTC 
Review of attachment 293971 [details] [review]:

As suggested in the other review, just combine this one, please.
Comment 9 Patrick Griffis (tingping) 2015-01-06 21:54:44 UTC 
Created attachment 293980 [details] [review]
Update libxml2 on osx
Comment 10 Patrick Griffis (tingping) 2015-01-06 21:58:50 UTC 
Created attachment 293982 [details] [review]
Bump required bison version to 2.4
Comment 11 Patrick Griffis (tingping) 2015-01-06 21:59:34 UTC 
Created attachment 293983 [details] [review]
Add cmake to osx bootstrap
Comment 12 Allison Karlitskaya (desrt) 2015-01-06 22:09:11 UTC 
Pushed all attachments with minor changes to the commit messages.