After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742473 - Small freebase oauth2 access bugs
Small freebase oauth2 access bugs
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-06 17:49 UTC by Carlos Garnacho
Modified: 2015-04-13 22:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
freebase: Fix authorization domain (1.21 KB, patch)
2015-01-06 17:50 UTC, Carlos Garnacho 		committed Details | Review
goa-authorizer: Add freebase domain (1.16 KB, patch)
2015-01-06 17:50 UTC, Carlos Garnacho 		committed Details | Review
goa-authorizer: Set Authorization header as "Bearer ..." (1.05 KB, patch)
2015-01-06 17:50 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2015-01-06 17:49:50 UTC 
I've noticed some buglets trying to setup the freebase API with a goa-based authorizer, I'm attaching a few patches to fix these.
Comment 1 Carlos Garnacho 2015-01-06 17:50:28 UTC 
Created attachment 293960 [details] [review]
freebase: Fix authorization domain

Set up as per https://developers.google.com/freebase/v1/how-tos/authorizing#AboutAuthorization.
Comment 2 Carlos Garnacho 2015-01-06 17:50:32 UTC 
Created attachment 293961 [details] [review]
goa-authorizer: Add freebase domain

This is necessary for authorizers to correctly authorize freebase queries.
Comment 3 Carlos Garnacho 2015-01-06 17:50:37 UTC 
Created attachment 293962 [details] [review]
goa-authorizer: Set Authorization header as "Bearer ..."

Starting with "OAuth..." seems a CnP/leftover from OAuth1 support. RFC
6750 only observes the "Bearer" keyword though. This also seems consistent
with GDataOAuth2Authorizer.
Comment 4 Philip Withnall 2015-01-07 00:23:31 UTC 
Review of attachment 293960 [details] [review]:

++
Comment 5 Philip Withnall 2015-01-07 00:24:56 UTC 
Review of attachment 293961 [details] [review]:

++
Comment 6 Philip Withnall 2015-01-07 00:27:20 UTC 
Review of attachment 293962 [details] [review]:

++ if it works. I’m surprised this didn’t get caught before.
Comment 7 Philip Withnall 2015-04-13 22:35:13 UTC 
Attachment 293960 [details] pushed as 5b34fea - freebase: Fix authorization domain
Attachment 293961 [details] pushed as aab9947 - goa-authorizer: Add freebase domain
Attachment 293962 [details] pushed as 4496726 - goa-authorizer: Set Authorization header as "Bearer ..."