After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742439 - closed add user dialog crashes when network changes
closed add user dialog crashes when network changes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-06 09:21 UTC by Ondrej Holy
Modified: 2015-01-06 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix crash when network changes (3.27 KB, patch)
2015-01-06 09:21 UTC, Ondrej Holy 		needs-work Details | Review
fix crash when network changes (1.21 KB, patch)
2015-01-06 11:05 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-01-06 09:21:38 UTC 
Created attachment 293902 [details] [review]
fix crash when network changes

Add user dialog crashes if it has been closed and network configuration changes, because the dialog is already disposed, but on_network_changes callback is executed. To fix this crash network monitor signal handler has to be disconnected on dispose.

This bug was introduced in 3.9.6, so 3-10, 3-12, 3-14 stable branches are also affected and should be fixed.

There is appropriate downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1147316
Comment 1 Bastien Nocera 2015-01-06 09:28:34 UTC 
Review of attachment 293902 [details] [review]:

Use g_signal_connect_object() instead? That'd be a one-line change.
Comment 2 Ondrej Holy 2015-01-06 11:05:16 UTC 
Created attachment 293912 [details] [review]
fix crash when network changes

I've thought that exists something like this function, but overlooked it in manual. Thanks that you pointed me on it!
Comment 3 Bastien Nocera 2015-01-06 11:13:57 UTC 
Review of attachment 293912 [details] [review]:

Looks good.
Comment 4 Ondrej Holy 2015-01-06 11:29:53 UTC 
Comment on attachment 293912 [details] [review]
fix crash when network changes

Committed to master, gnome-3-14, 3-12 and 3-10. Thanks for review!