Bug 742421 – css parser is broken possibly due to scss api changes

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 742421 - css parser is broken possibly due to scss api changes


Summary:	css parser is broken possibly due to scss api changes


Status:	RESOLVED FIXED

Product:	gnome-code-assistance
Classification:	Other
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Code Assistance maintainers
QA Contact:	GNOME Code Assistance maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-01-05 22:19 UTC by Christian Hergert
Modified:	2015-04-15 19:06 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
css: fix css backend for scss api changes. (1.38 KB, patch) 2015-01-05 22:20 UTC, Christian Hergert	none	Details \| Review

Description Christian Hergert 2015-01-05 22:19:59 UTC

Seeing a lot of this when trying to initialize the CSS backend.

2015/01/05 14:01:28.2600  starfield:       code-assistant[3310]:  WARNING: GDBus.Error:org.freedesktop.DBus.Error.Failed: wrong number of arguments (2 for 3..5)
	from /usr/share/gems/gems/sass-3.3.8/lib/sass/scss/parser.rb:25:in `initialize'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/css/app.rb:73:in `new'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/css/app.rb:73:in `parse'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/transport/dbus.rb:92:in `block (2 levels) in <module:Service>'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/export.rb:81:in `call'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/export.rb:81:in `dispatch'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/transport/dbus.rb:310:in `dispatch'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/bus.rb:659:in `process'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/bus.rb:855:in `block in run'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/bus.rb:846:in `each'
	from /usr/share/gems/gems/ruby-dbus-0.9.0/lib/dbus/bus.rb:846:in `run'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/transport/dbus.rb:316:in `run'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/transport/dbus.rb:338:in `run'
	from /usr/libexec/gnome-code-assistance/backends/rb/gnome/codeassistance/css/app.rb:94:in `run'
	from /usr/libexec/gnome-code-assistance/css:6:in `<main>'

Patch coming.

Comment 1 Christian Hergert 2015-01-05 22:20:35 UTC

Created attachment 293880 [details] [review]
css: fix css backend for scss api changes.

We need to specify an importer for the parser classes now. I suspect
this changed upstream at somepoint and nobody knew about it.

Trivial fix, however we might consider using a project path to determine
where the top of the CSS imports should be.

Comment 2 jessevdk@gmail.com 2015-01-10 13:12:40 UTC

Thanks for the fix! I've pushed it plus some additional fixes. The reason it took me a bit longer is because I wanted to check when the signature of the Parser class was changed. If sass is not found on the system, we distribute our own vendored version of sass (since installing the sass gem from package for distros can be hairy). The version we were distributing was too old and needed to be updated as well. Finally, I've added version checks for sass so when sass on the system is too old, we use the vendored one.

Comment 3 Christian Hergert 2015-04-15 19:06:41 UTC

Looks like we forgot to close. Marking fixed.