After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742415 - git master fails to build in continuous
git master fails to build in continuous
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-05 21:24 UTC by Colin Walters
Modified: 2015-05-01 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Another gtksourceview bindings change... (929 bytes, patch)
2015-01-06 21:58 UTC, Michael Catanzaro
committed Details | Review

Description Colin Walters 2015-01-05 21:24:00 UTC
See http://build.gnome.org/continuous/buildmaster/builds/2015/01/05/44/build/log-gnome-calculator.txt

More gtksourceview vala bindings issues?

In the meantime, I'm going to do the same thing I did last time and remove gnome-calculator from the manifest.
Comment 1 Colin Walters 2015-01-05 21:24:40 UTC
Please revert https://git.gnome.org/browse/gnome-continuous/commit/?id=bee207ab5fd46b1e90538a66f7fb69c0292472bf when this is fixed.
Comment 2 Michael Catanzaro 2015-01-06 21:58:13 UTC
The following fix has been pushed:
67ecaa4 Another gtksourceview bindings change...
Comment 3 Michael Catanzaro 2015-01-06 21:58:16 UTC
Created attachment 293981 [details] [review]
Another gtksourceview bindings change...
Comment 4 Michael Catanzaro 2015-01-06 22:02:32 UTC
By the way, it is *really* suspicious to return uninitialized memory in an out parameter. I wonder why we override that function at all.
Comment 6 Colin Walters 2015-01-06 22:16:22 UTC
Er sorry, that run hadn't done a git fetch becuase it wasn't in the manifest.  Latest master builds after a resolve.  Thanks!
Comment 7 Alberts Muktupāvels 2015-05-01 14:02:36 UTC
I am building GNOME 3.14 and got this error. Maybe this fix should be pushed to gnome-3-14 too?
Comment 8 Michael Catanzaro 2015-05-01 15:30:09 UTC
TBH I think gtksourceview should not have backported an API break (March 5, 2015) seven months after the 3.14 API freeze (August 18, 2014); best bet would be to downgrade gtksourceview.
Comment 9 Alberts Muktupāvels 2015-05-01 15:43:26 UTC
How do you downgrade gtksourceview in jhbuild? Or now everyone who builds GNOME with jhbuild will need to deal with this manually?
Comment 10 Michael Catanzaro 2015-05-01 18:35:21 UTC
TBH, it's a bit much to expect the gnome-3-14 jhbuild modulesets to work now that GNOME 3.16 has been released, but if you want to fix it, the options are (a) ask the gtksourceview developers to revert their vala API break, (b) ask the gtksourceview developers to work around the return value change in their vapi generation, or (c) have jhbuild build gtksourceview from a tarball release rather than from git (undesirable, so please only change that in the 3.14 moduleset).

Or just upgrade to 3.16, where we already adapted to that API change.