After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742373 - The app should have a minimum window height
The app should have a minimum window height
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-05 12:23 UTC by Miguel Vaello Martínez
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14

Attachments
Patch to keep a minimum window height (1.42 KB, patch)
2015-01-05 13:01 UTC, Miguel Vaello Martínez 		none Details | Review
window: Setting window minimum height size (17.99 KB, patch)
2015-01-09 22:56 UTC, Miguel Vaello Martínez 		none Details | Review
window: Setting window minimum height size (1.13 KB, patch)
2015-01-09 23:20 UTC, Miguel Vaello Martínez 		committed Details | Review

Description Miguel Vaello Martínez 2015-01-05 12:23:17 UTC 
The window properties allow to reduce the window height by complete. This have no sense because it doesn't allow to see well (or nothing) the calendar sheet despite the responsive view properties.
Comment 1 Miguel Vaello Martínez 2015-01-05 13:01:37 UTC 
Created attachment 293816 [details] [review]
Patch to keep a minimum window height

In this patch has been used "gtk_window_set_geometry_hints" method for apply a min window size. Through GtkGeometry struct definitions, has been defined the min_width and min_height  with values.
Comment 2 Georges Basile Stavracas Neto 2015-01-08 22:38:50 UTC 
You can simply set the "height_request" property directly into data/ui/window.ui file.
Could you craft another patch for it?

Thanks in advance!
Comment 3 Miguel Vaello Martínez 2015-01-09 11:02:20 UTC 
> You can simply set the "height_request" property directly into
> data/ui/window.ui file.
> Could you craft another patch for it?
> 
> Thanks in advance!

Yes, of course. This afternoon I am going to submit the right patch. Sometimes I forget that I can do the things in a simpler way using the ui files. :/(In reply to comment #2)
Comment 4 Miguel Vaello Martínez 2015-01-09 22:56:05 UTC 
Created attachment 294188 [details] [review]
window: Setting window minimum height size
Comment 5 Georges Basile Stavracas Neto 2015-01-09 23:18:03 UTC 
(In reply to comment #4)
> Created an attachment (id=294188) [details] [review]
> window: Setting window minimum height size

Can you please post the patch? The attached file is the whole UI file.
Comment 6 Miguel Vaello Martínez 2015-01-09 23:20:01 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=294188) [details] [review] [details] [review]
> > window: Setting window minimum height size
> 
> Can you please post the patch? The attached file is the whole UI file.

Opps sorry.
Comment 7 Miguel Vaello Martínez 2015-01-09 23:20:36 UTC 
Created attachment 294194 [details] [review]
window: Setting window minimum height size
Comment 8 Georges Basile Stavracas Neto 2015-01-09 23:29:54 UTC 
Review of attachment 294194 [details] [review]:

Simple and with a good commit message.
Comment 9 Georges Basile Stavracas Neto 2015-01-09 23:30:27 UTC 
Fixed. Commit 7f95a80bce7f8e3486cc58b8cd12b8e01f295a3e.

Thanks for your work on this issue!