Bug 742341 – filebrowser plugin: use popover instead of combo box

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 742341 - filebrowser plugin: use popover instead of combo box


Summary:	filebrowser plugin: use popover instead of combo box

Attachments
use a popover instead of a combo box (21.47 KB, patch) 2015-01-04 21:20 UTC, sébastien lafargue	committed	Details \| Review
screenshot 1 (66.78 KB, image/png) 2015-01-05 17:06 UTC, sébastien lafargue		Details
screenshot 2 (47.17 KB, image/png) 2015-01-05 17:08 UTC, sébastien lafargue		Details

Description sébastien lafargue 2015-01-04 21:18:51 UTC

filebrowser plugin: use popover instead of combo box

Comment 1 sébastien lafargue 2015-01-04 21:20:09 UTC

Created attachment 293725 [details] [review]
use a popover instead of a combo box

Comment 2 Ignacio Casal Quinteiro (nacho) 2015-01-05 07:15:11 UTC

Review of attachment 293725 [details] [review]:

The code looks ok at a quick look. Can you post a screenshot?

Comment 3 sébastien lafargue 2015-01-05 17:06:42 UTC

Created attachment 293842 [details]
screenshot 1

Comment 4 sébastien lafargue 2015-01-05 17:08:15 UTC

Created attachment 293844 [details]
screenshot 2

Comment 5 Paolo Borelli 2015-01-05 17:39:33 UTC

looks good to me

Comment 6 Ignacio Casal Quinteiro (nacho) 2015-01-05 17:41:59 UTC

not related to this patch specifically but is it me or the buttons <> are not linked anymore?

Comment 7 sébastien lafargue 2015-01-05 18:24:03 UTC

Review of attachment 293725 [details] [review]:

commited as 15f89b2