After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742333 - Toggling "dark theme variant" doesn't update inactive tabs
Toggling "dark theme variant" doesn't update inactive tabs
Status: RESOLVED OBSOLETE
Product: gnome-terminal
Classification: Core
Component: Profiles
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-04 18:40 UTC by Egmont Koblinger
Modified: 2016-02-21 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Egmont Koblinger 2015-01-04 18:40:36 UTC
Have g-t with multiple tabs, each with a profile that has enabled Profile prefs -> Colors -> Use colors from system theme.

Toggle g-t's global Preferences -> Use dark theme variant. All the currently visible windows and tabs are updated.

Switch to another tab. Notice that this tab still uses the old theme variant's fg/bg colors; the opposite of what it should use.

The given tab is repaired when the window loses/gains focus. All other tabs still remain broken until once they're the active on a focus change.
Comment 1 Egmont Koblinger 2015-01-07 20:18:25 UTC
ChPe, could you please take this one?

I'm totally lost in the maze of signals and can't see what the right approach would be :)
Comment 2 Christian Persch 2015-01-07 21:17:05 UTC
Hmm. With all the problems this setting causes, I'm tempted to just remove it.
Comment 3 Egmont Koblinger 2015-01-07 22:21:17 UTC
:D

... and let Fedora patch their g-t or give up on dark terminal?

More important things (like word chars, easy title setting) were already removed, so I won't shed a tear for it. Although it would be cool if it worked, some people might find it cool to have the look that's shipped by F21.

Is there a low-level hack (adding a couple of lines to gtk.css) that would bring back this look for experts?
Comment 4 Christian Persch 2015-12-15 20:01:47 UTC
The setting was brought back, so I'm wondering if this is still reproducible? If so, it would likely be a gtk+ bug, cause being a missing style-updated signal (the handler of that signal is where we update our colours to match the theme).
Comment 5 Christian Persch 2016-02-21 14:20:38 UTC
Let's call this OBSOLETE unless someone can still repro.