GNOME Bugzilla – Bug 742316
Remove the FSF postal address from copyright comments
Last modified: 2015-05-02 19:41:40 UTC
We do not want to track the postal address of the FSF instead we should rewrite them such as: * You should have received a copy of the GNU General Public License along * with GNOME Maps; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA => * You should have received a copy of the GNU General Public License along * with GNOME Maps; if not, see <http://www.gnu.org/licenses/>.
I assume the file that contains the GPL2 itself, COPYING, must track the address. Thus, not changed.
Created attachment 301433 [details] [review] Deleted references to postal address of FSF It's been replaced by gnu.org licenses page
Review of attachment 301433 [details] [review]: The commit message should be in present tense, that is something like: "Delete references to FSF postal address Replace it with gnu.org licenses page" ...otherwise fine. The patch looks good otherwise! Thanks! :)
Wow, awesome work :) So many files! Didn't know what I asked of you. I agree with Mattias comment, I can fix up the commit message while merging it, or you can update the patch. Your choice. Thanks!
Created attachment 301437 [details] [review] Delete references to FSF postal address Replace it with gnu.org licenses page
Review of attachment 301437 [details] [review]: Thanks! I will mark the other patch as obosolete! Do you know about git-bz? http://blog.fishsoup.net/2008/11/16/git-bz-bugzilla-subcommand-for-git/ It can help with this workflow!
I'm attaching the patches using git bz ^^. Can be marked as obsolete a previous patch from git bz?
nice! Yes, it is automagical if the patch has the same subject line. In your case you would have needed to use the 'git bz attach -e' flag with your command and you would have been able to tell bugzilla to obsolete the previous patch.