GNOME Bugzilla – Bug 742253
Some settings shouldn't be per language
Last modified: 2015-01-11 03:53:30 UTC
Especially settings altering the appearance of the editor shouldn't be per language. If I want line numbers I usually don't want to set that for every language again. IMO the following settings should be global for the editor: * Display line numbers * Display line marks (though I don't fully understand this setting - IMO a better description is needed here) * Home moves to first non-whitespace character * Highlight current line * Highlight matching brackets * Enable indentation
Agreed. Let's make these global: * Line Numbers * Highlight current line * Highlight matching brackets * Home moves to first non-whitespace character Let's remove this altogether: * Show line marks I don't want to make global: * Enable Indentation This is because I'm concerned at the quality of auto-indentation per language. Some languages will be better than others, and some will use the GtkSourceView fallback which is rather annoying. Care to cook up a patch/ui change?
Sounds good. I'm currently looking at the code, trying to make a patch. But I can't make guarantees, exams are coming ;)
Created attachment 293750 [details] [review] Settings from org.gnome.builder.editor.language to org.gnome.builder.editor Move settings * show-line-numbers * highlight-current-line * highlight-matching-braces * smart-home from org.gnome.builder.editor.language to org.gnome.builder.editor and remove the checkbox from language settings widget
What about the ui?Shall we add a GtkSwitch for each of those 4 setttings into the editor settings widget?
(In reply to comment #4) > What about the ui?Shall we add a GtkSwitch for each of those 4 setttings into > the editor settings widget? I'd do it this way since it is consistent with the other settings. And it doesn't look as ugly and uninformative as checkboxes since it provides more information. If we want an alternative we'd need a refactoring of the existent settings, this is probably needed at some point anyway with the consultation of the design team IMO.
Review of attachment 293750 [details] [review]: I didn't have time to look at the code yet but you should reformat the commit message. You can find guidelines for that here: https://wiki.gnome.org/Git/CommitMessages I'd also suggest to also put the reason for the change in the message so the user doesnt need to go to bugzilla.
I will have an additional patch soon with all the other changes.I will follow the guidelines as said on my final patch. Thanks
Created attachment 294128 [details] [review] Move some settings from org.gnome.builder.editor.language to org.gnome.builder.editor Move settings * Line Numbers * Highlight current line * Highlight matching brackets * Home moves to first non-whitespace character from org.gnome.builder.editor.language to org.gnome.builder.editor Removed setting * Show line marks
Pushed to master.