After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742214 - add AppStream to show in Software Centres
add AppStream to show in Software Centres
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-02 02:10 UTC by Igor Gnatenko
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add AppStream to show in Software Centres (3.53 KB, patch)
2015-01-02 02:10 UTC, Igor Gnatenko
none Details | Review
add AppStream to show in Software Centres (3.52 KB, patch)
2015-01-02 02:11 UTC, Igor Gnatenko
none Details | Review
add AppStream to show in Software Centres (4.11 KB, patch)
2015-01-02 02:28 UTC, Igor Gnatenko
needs-work Details | Review
add AppStream to show in Software Centres (4.11 KB, patch)
2015-01-06 00:49 UTC, Igor Gnatenko
none Details | Review
appdata: added some images (138.13 KB, patch)
2015-01-06 00:49 UTC, Igor Gnatenko
none Details | Review
appdata: update image url's (1.68 KB, patch)
2015-01-06 00:49 UTC, Igor Gnatenko
none Details | Review
add AppStream to show in Software Centres (4.11 KB, patch)
2015-01-06 20:26 UTC, Igor Gnatenko
committed Details | Review
appdata: added some images and update URIs in xml (139.59 KB, patch)
2015-01-06 20:26 UTC, Igor Gnatenko
committed Details | Review

Comment 1 Igor Gnatenko 2015-01-02 02:10:14 UTC
Created attachment 293584 [details] [review]
add AppStream to show in Software Centres

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Comment 2 Igor Gnatenko 2015-01-02 02:11:46 UTC
Created attachment 293585 [details] [review]
add AppStream to show in Software Centres

https://bugzilla.gnome.org/show_bug.cgi?id=742214
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 3 Igor Gnatenko 2015-01-02 02:28:19 UTC
Created attachment 293587 [details] [review]
add AppStream to show in Software Centres

v2:
    add DISTCHECK_CONFIGURE_FLAGS to check AppStream data
    add data/appdata/Makefile in configure.ac, because it's needed
Comment 4 Erick Perez Castellanos 2015-01-05 21:09:16 UTC
Review of attachment 293587 [details] [review]:

Thxs for your work on this.

::: data/appdata/org.gnome.Calendar.appdata.xml.in
@@ +24,3 @@
+  <screenshots>
+    <screenshot type="default">
+      <image width="1366" height="768">https://feaneron.files.wordpress.com/2014/12/captura-de-tela-de-2014-12-23-191620.png</image>

Could you change this for some png added to the repo in a previous patch?

@@ +28,3 @@
+    <screenshot>
+      <_caption>Search for events</_caption>
+      <image width="1366" height="768">https://feaneron.files.wordpress.com/2014/12/captura-de-tela-de-2014-12-23-184243.png</image>

Same here

@@ +32,3 @@
+    <screenshot>
+      <_caption>Calendar management</_caption>
+      <image width="1377" height="798">https://feaneron.files.wordpress.com/2014/12/calendar-selector.jpg</image>

Same here
Comment 5 Igor Gnatenko 2015-01-06 00:49:07 UTC
Created attachment 293890 [details] [review]
add AppStream to show in Software Centres

https://bugzilla.gnome.org/show_bug.cgi?id=742214
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 6 Igor Gnatenko 2015-01-06 00:49:17 UTC
Created attachment 293891 [details] [review]
appdata: added some images

After all, it's all about marketing.
Comment 7 Igor Gnatenko 2015-01-06 00:49:24 UTC
Created attachment 293892 [details] [review]
appdata: update image url's
Comment 8 Igor Gnatenko 2015-01-06 00:53:37 UTC
(In reply to comment #7)
> Created an attachment (id=293892) [details] [review]
> appdata: update image url's
if all patches ok - I'll squas 2 last patches and drop from url wip/appdata
Comment 9 Erick Perez Castellanos 2015-01-06 15:48:07 UTC
(In reply to comment #6)
> Created an attachment (id=293891) [details] [review]
> appdata: added some images
> 
> After all, it's all about marketing.

I'll rather the images were taken using the default theme of GNOME.
Comment 10 Igor Gnatenko 2015-01-06 20:26:02 UTC
Created attachment 293974 [details] [review]
add AppStream to show in Software Centres

https://bugzilla.gnome.org/show_bug.cgi?id=742214
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Comment 11 Igor Gnatenko 2015-01-06 20:26:14 UTC
Created attachment 293975 [details] [review]
appdata: added some images and update URIs in xml

Images were taken with default GNOME theme and has more better
resolution.

Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>