After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742186 - configure.ac: save LDFLAGS during tests
configure.ac: save LDFLAGS during tests
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2015-01-01 18:43 UTC by Marcus Meissner
Modified: 2015-07-04 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker-save-ldflags.patch (1.78 KB, patch)
2015-01-01 18:43 UTC, Marcus Meissner 		accepted-commit_now Details | Review
configure: Save LDFLAGS (2.83 KB, patch)
2015-07-04 18:37 UTC, Carlos Garnacho 		none Details | Review

Description Marcus Meissner 2015-01-01 18:43:55 UTC 
Created attachment 293567 [details] [review]
tracker-save-ldflags.patch

if you have special LDFLAGS and CFLAGS combinations (like -fPIE / -pie) confiogure will have problems due to clearing CFLAGS but not LDFLAGS.

ATtached patch does save also LDFLAGS
Comment 1 Martyn Russell 2015-01-02 08:48:02 UTC 
Comment on attachment 293567 [details] [review]
tracker-save-ldflags.patch

Thanks for the patch, looks good to me. Please commit :)
Comment 2 Carlos Garnacho 2015-07-04 18:31:37 UTC 
Thanks for the patch, it missed a last appearance on m4/sqlite-builtin-fts4 :). I updated the patch and am pushing now to master.
Comment 3 Carlos Garnacho 2015-07-04 18:37:06 UTC 
The following fix has been pushed:
62d44fe configure: Save LDFLAGS
Comment 4 Carlos Garnacho 2015-07-04 18:37:10 UTC 
Created attachment 306829 [details] [review]
configure: Save LDFLAGS

There's places where CFLAGS is modified/restored while LDFLAGS is left
untouched, both should be saved/restored at the same time.