After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742145 - Use GtkHeaderBar
Use GtkHeaderBar
Status: RESOLVED FIXED
Product: almanah
Classification: Other
Component: General
0.11.x
Other Linux
: Normal enhancement
: ---
Assigned To: diary-maint
diary-maint
Depends on: 743086 743096 743097
Blocks:
 
 
Reported: 2014-12-31 11:02 UTC by Álvaro Peña
Modified: 2015-03-02 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Migration from GtkToolbar to GtkHeaderBar following the design (28.84 KB, patch)
2015-03-01 17:18 UTC, Álvaro Peña 		accepted-commit_now Details | Review

Description Álvaro Peña 2014-12-31 11:02:51 UTC 
At the moment, Almanah is using a GtkToolBar with some custom widgets. Migrate Almanah to GtkHeaderBar. This require some intermediate steps:

0. Mockup the header bar first.
1. Use GResource.
2. Migrate to GAction from GtkAction, splitting into a new XML file.
3. Migrate to GtkBuilder, removing GtkUIManager (currently deprecated).
4. Use GtkHeaderBar into the main window following the design done in 0.
Comment 1 Philip Withnall 2015-01-06 00:41:01 UTC 
Might want to split steps 1, 2 and 3 out into separate bugs to make this a bit easier to track.
Comment 2 Álvaro Peña 2015-01-17 16:46:36 UTC 
(In reply to comment #1)
> Might want to split steps 1, 2 and 3 out into separate bugs to make this a bit
> easier to track.

Yes, your right.
Comment 3 Álvaro Peña 2015-02-20 18:11:10 UTC 
I have been working in a new design available in the wiki: https://wiki.gnome.org/Apps/Almanah_Diary/Design

The first mockup is here: https://wiki.gnome.org/Apps/Almanah_Diary/Design?action=AttachFile&do=get&target=almanah_mainwindow.png

I'm working in the popovers which will be shown in the calendar, tags and "hamburger" buttons in the header bar.
Comment 4 Álvaro Peña 2015-03-01 17:18:40 UTC 
Created attachment 298217 [details] [review]
Migration from GtkToolbar to GtkHeaderBar following the design
Comment 5 Álvaro Peña 2015-03-02 19:12:24 UTC 
Review of attachment 298217 [details] [review]:

Ok.