After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742077 - Split pane mode: unsaved file indicator appears on unmodified left file when right file is modified
Split pane mode: unsaved file indicator appears on unmodified left file when ...
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-29 03:38 UTC by Michael Catanzaro
Modified: 2015-01-13 05:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screencast (1.16 MB, application/octet-stream)
2014-12-29 03:38 UTC, Michael Catanzaro 		  Details
documents-button: assign the right binding to the weak pointer (1.26 KB, patch)
2015-01-13 05:13 UTC, Christian Hergert 		committed Details | Review

Description Michael Catanzaro 2014-12-29 03:38:38 UTC 
Created attachment 293420 [details]
screencast

* Open Builder.
* Open two different files.
* Use Move Document Right to enter split pane mode.
* (At this point, you have two different panes open with two different files.)
* Modify the file on the right. Note that the unsaved file indicator appears for both the file on the right and the file on the left, even though the file on the left is unmodified.

Modifying the file on the left works properly, i.e. the unsaved file indicator never appears for the file on the right unless the file on the right is actually modified.

When the unsaved file indicator improperly appears for the file on the left, it appears only on the long menu button that you click on to open the popover. It does not appear in the file list inside the popover. Confused yet? Screencast attached.
Comment 1 Christian Hergert 2015-01-13 05:13:24 UTC 
Created attachment 294384 [details] [review]
documents-button: assign the right binding to the weak pointer

We were assigning the title binding to the modified binding location,
which could cause the modified label to get out of sync.
Comment 2 Christian Hergert 2015-01-13 05:14:08 UTC 
Thanks for reporting this, finally had a chance to track it down.

Attachment 294384 [details] pushed as fe3ec13 - documents-button: assign the right binding to the weak pointer