After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742043 - Accelerator for Search is confusing
Accelerator for Search is confusing
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-28 03:08 UTC by Michael Catanzaro
Modified: 2014-12-28 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keybindings: support different keybindings between default and vim mode (9.58 KB, patch)
2014-12-28 11:03 UTC, Christian Hergert 		committed Details | Review

Description Michael Catanzaro 2014-12-28 03:08:45 UTC 
Currently, the accelerator for search is Ctrl+Shift+F. This is confusing: it should be Ctrl+F instead, at least when not in vim mode.  (I think you mentioned that Ctrl+F is currently reserved for use in vim mode.)
Comment 1 Christian Hergert 2014-12-28 11:03:06 UTC 
Created attachment 293392 [details] [review]
keybindings: support different keybindings between default and vim mode

This reloads keybindings when vim-mode setting changes. This allows us to
have custom keybinding themes for each.
Comment 2 Christian Hergert 2014-12-28 11:04:05 UTC 
The patch adds support for having two sets of keybindings. Default, and when vim mode is enabled. when org.gnome.builder.editor.vim-mode boolean setting changes, we switch the loaded keybindings.
Comment 3 Christian Hergert 2014-12-28 11:04:33 UTC 
Attachment 293392 [details] pushed as e7b4c79 - keybindings: support different keybindings between default and vim mode