GNOME Bugzilla – Bug 742013
Boxes uses old URLs to link to the wiki
Last modified: 2016-03-31 13:22:07 UTC
Boxes links to http://live.gnome.org instead of https://wiki.gnome.org in a number of places as well as to the wiki instead of the website for brand guidelines. The only link which will still be broken because it appears to no longer exist after the patches which I will attach shortly is in /src/unattended-installer.vala to https://wiki.gnome.org/Boxes/unattended
Created attachment 293369 [details] [review] patch to fix links except the one which is mentioned in the first comment
Created attachment 293370 [details] [review] improve linking to the home page by always taking the link from configure.ac
Review of attachment 293369 [details] [review]: Hi, thanks for the patch. We usually put the bug URL into the description of the commit message, not in the shortlog. If you don't mind, we'll change that before pushing.
Review of attachment 293370 [details] [review]: Same thing here, we'd rather put the bug URL on an own line, like in the example on https://wiki.gnome.org/Git/CommitMessages . Good otherwise.
The broken link you mentioned is just an internal ID for our installation script. It will never be exposed to the user. More information is available here: http://valadoc.org/#!api=libosinfo-1.0/Osinfo.InstallConfig
Libosinfo has the habit of using URL-style IDs which is a bit confusing when you're looking at the project without knowing this. So yes, they don't exist and never existed.
Comment on attachment 293369 [details] [review] patch to fix links except the one which is mentioned in the first comment Pushed to master in commit 56846001fde74559c4bc740311a75bd508e6b02d
Comment on attachment 293370 [details] [review] improve linking to the home page by always taking the link from configure.ac Pushed to master in commit 47671d70fe61bf250c6435b52047dede8be261b1