GNOME Bugzilla – Bug 741986
missing dependency on icon theme
Last modified: 2015-01-03 13:26:08 UTC
Here is a note from one of our users: "Since the update to the 3.14 series, gedit doesn't take into account that in order to be usable, it really needs to have an explicit dependency marked on graphics/adwaita-icon-theme, otherwise various icons will be missing, and as this new version has done away with the traditional menu system, it's a bit crippled without these icons. Without that package installed, I'm presented with various unlabelled buttons and can't even see the close icon on tabs." I can see gedit arguing "we are being theme agnostic, you must install a theme." Yet, gedit's osx builder depends on adwaita-icon-theme, so someone thought otherwise. Another take would be to say "gtk used to provide stock icons, adwaita theme is the default theme, so make gtk depend on adwaita" Discuss?
It can be documented in the README. And if it's possible to add the dependency check in configure.ac, then it's even better.
Created attachment 293632 [details] [review] note run-time dependency on icon theme in README I still haven't figured out The Right Way of dealing with this. In the old days, it was simple: gtk provided stock icons, the program depended on gtk. If someone wanted an extra theme that was fine. If I add a compile time dependency in configure.ac, then I impose an unnecessary constraint on the build box (e.g. a box doing bulk builds, which needs relevant shared libraries installed, but surely not icons(!) - which wouldn't guarantee success when run on the client machine anyway.) So, attached is just a note for the README file. (No doubt wording could be improved.)
Review of attachment 293632 [details] [review]: It's fine for me.
Thanks - committed as https://git.gnome.org/browse/gedit/commit/?id=42baf641e324fc1daade863eb89d97dc4bde580f (If you think of a better solution please let me know!)