After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741969 - GTK_STOCK_COPY
GTK_STOCK_COPY
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
3.15.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-12-25 16:49 UTC by Morten Welinder
Modified: 2015-03-05 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Point to copy/cut/delete named icons in the stock item deprecations (1.64 KB, patch)
2014-12-26 16:06 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Morten Welinder 2014-12-25 16:49:19 UTC 
GTK_STOCK_COPY etc. are deprecated with

    Deprecated: 3.10: Do not use an icon. Use label "_Copy".

The "Do not use an icon" part does not seem right.  You really cannot
have a toolbar full of icons and just have a hole where copy/paste/cut
resides.

Suggestion: point at edit-copy, etc.
Comment 1 Emmanuele Bassi (:ebassi) 2014-12-26 16:06:33 UTC 
Created attachment 293359 [details] [review]
Point to copy/cut/delete named icons in the stock item deprecations

We still use symbolic icons for Copy, Cut, and Delete operations inside
toolbars and some menus, so it's worth pointing to the symbolic icon
names in the deprecation notices.
Comment 2 Matthias Clasen 2015-01-09 04:50:36 UTC 
Attachment 293359 [details] pushed as 79f806f - Point to copy/cut/delete named icons in the stock item deprecations
Comment 3 Kjell Ahlstedt 2015-03-05 18:08:08 UTC 
The patch recommends "edit-cut" as replacement for both GTK_STOCK_CUT and
GTK_STOCK_DELETE. Shouldn't GTK_STOCK_DELETE be replaced by "edit-delete"?

What about paste? If you recommend icons for copy and cut, shouldn't you
recommend the "edit-paste" icon as replacement for GTK_STOCK_PASTE?
Comment 4 Matthias Clasen 2015-03-05 21:10:23 UTC 
I've fixed that up, thanks