After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741952 - nautilus crashes when closing window with several tabs opened
nautilus crashes when closing window with several tabs opened
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
3.14.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 722616 743017 745934 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-12-24 22:45 UTC by Ashish Bhurtel
Modified: 2015-04-01 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix nautilus crash when closing window with several tabs (1.64 KB, patch)
2014-12-26 20:11 UTC, Nelson Benitez 		committed Details | Review
Revert "nautilus-window: Check for valid location entry widget" (1.20 KB, patch)
2014-12-27 00:26 UTC, Michael Catanzaro 		committed Details | Review

Description Ashish Bhurtel 2014-12-24 22:45:07 UTC 
Overview: This is bug in version of nautilus 3.14.2 these are steps for reproducing this bug

Steps to reproduce the bug:
1. Open home folder in nautilus
2. open any other folder in nautilus (for example documents in new tab using open in new tab).
3. Then close the nautilus file manager when there are two tabs opened.

Action Results: Nautilus Crashes

Expected Result: the nautilus file manager should close instead of crashing.

Build Date & Platform: Fedora 21 build
Comment 1 Nelson Benitez 2014-12-26 20:11:00 UTC 
Created attachment 293363 [details] [review]
Fix nautilus crash when closing window with several tabs

When destroying window and closing all slots, the closing of the active slot will trigger activation of next free slot, we don't want to be activating slots as part of 'closing all slots' logic. 

This was causing a crash in nautilus_window_sync_location_widgets() function (called when activating a slot) because it tried to access the nautilus path bar which was already gone.
Comment 2 Michael Catanzaro 2014-12-27 00:23:31 UTC 
*** Bug 722616 has been marked as a duplicate of this bug. ***
Comment 3 Michael Catanzaro 2014-12-27 00:26:32 UTC 
Created attachment 293371 [details] [review]
Revert "nautilus-window: Check for valid location entry widget"

This reverts commit 8acef3c776f2ef4f5dac788ed81f7e2d1f504026.

See comments in bug #722616
Comment 4 Cosimo Cecchi 2014-12-27 11:22:51 UTC 
Review of attachment 293363 [details] [review]:

Thanks for the patch!
Comment 5 Cosimo Cecchi 2014-12-27 11:23:07 UTC 
Review of attachment 293371 [details] [review]:

Looks good to commit with the other patch.
Comment 6 Nelson Benitez 2014-12-27 15:21:22 UTC 
I've committed both patches, thanks Cosimo and Michael.
Comment 7 Nelson Benitez 2015-01-19 15:35:10 UTC 
*** Bug 743017 has been marked as a duplicate of this bug. ***
Comment 8 Sebastien Bacher 2015-04-01 10:03:54 UTC 
*** Bug 745934 has been marked as a duplicate of this bug. ***