After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741936 - gtkpopover: fix unguarded use of wayland symbols
gtkpopover: fix unguarded use of wayland symbols
Status: RESOLVED DUPLICATE of bug 738891
Product: gtk+
Classification: Platform
Component: Widget: GtkPopover
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-12-24 02:59 UTC by Allison Karlitskaya (desrt)
Modified: 2014-12-24 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkpopover: fix unguarded use of wayland symbols (1.08 KB, patch)
2014-12-24 02:59 UTC, Allison Karlitskaya (desrt) 		none Details | Review

Description Allison Karlitskaya (desrt) 2014-12-24 02:59:17 UTC 
96f7c11f4840d7425ab19290ea18d3904ab939a1 introduced an unconditional use
of GDK_IS_WAYLAND_DISPLAY.  Guard that with ifdef GDK_WINDOWING_WAYLAND.
Comment 1 Allison Karlitskaya (desrt) 2014-12-24 02:59:19 UTC 
Created attachment 293316 [details] [review]
gtkpopover: fix unguarded use of wayland symbols
Comment 2 Emmanuele Bassi (:ebassi) 2014-12-24 14:16:08 UTC 
the patch from Ting-wei Lan in bug 738891 — attachment 293322 [details] [review] — is a bit better, because it avoids the empty `if (0) ;` just by moving the `else` inside the #ifdef GDK_WINDOWING_WAYLAND ... #endif block.
Comment 3 Allison Karlitskaya (desrt) 2014-12-24 14:19:33 UTC 
Hah.  I did it that way first and changed it because I didn't like how it messed with the indentation :)

Very well.

*** This bug has been marked as a duplicate of bug 738891 ***