After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741925 - Respect Gtk/DialogsUseHeader for dialogs
Respect Gtk/DialogsUseHeader for dialogs
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2014-12-23 21:08 UTC by Iain Lane
Modified: 2015-02-15 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Respect use-header-bar for the properties dialog (26.69 KB, patch)
2014-12-23 21:08 UTC, Iain Lane
none Details | Review
ask-password: Use gtk-dialogs-use-header GtkSetting (17.65 KB, patch)
2014-12-23 21:08 UTC, Iain Lane
none Details | Review
password: Use gtk-dialogs-use-header GtkSetting (15.02 KB, patch)
2014-12-23 21:09 UTC, Iain Lane
none Details | Review
request-dialog: Use gtk-dialogs-use-header GtkSetting (7.24 KB, patch)
2014-12-23 21:09 UTC, Iain Lane
none Details | Review
delete: Use gtk-dialogs-use-header GtkSetting (16.86 KB, patch)
2014-12-23 21:09 UTC, Iain Lane
none Details | Review
dlg-add: Respect the DialogsUseHeader gtksetting (2.63 KB, patch)
2014-12-23 21:09 UTC, Iain Lane
none Details | Review
fr-new-archive-dialog: respect gtk-dialogs-use-header (1.13 KB, patch)
2015-01-08 17:07 UTC, Iain Lane
none Details | Review

Description Iain Lane 2014-12-23 21:08:47 UTC
In 3.14, dialogs started using headerbars unconditionally. Not all environments
want this. Fortunately there is a GtkSetting to express this - this patch
series is about respecting that setting.

The snag is that this is a construct-only property, so we have to move the
GtkDialog out into code to set the value at construct time.

The idea is that there's no change for the headerbar case, and the buttons move
to the action area for the non-headerbar. Test it with something like:

  gsettings set org.gnome.settings-daemon.plugins.xsettings overrides "{'Gtk/DialogsUseHeader': <0>}"
Comment 1 Iain Lane 2014-12-23 21:08:50 UTC
Created attachment 293297 [details] [review]
Respect use-header-bar for the properties dialog

This is a construct-only property so you cannot set this from a .ui
file.
Comment 2 Iain Lane 2014-12-23 21:08:56 UTC
Created attachment 293298 [details] [review]
ask-password: Use gtk-dialogs-use-header GtkSetting
Comment 3 Iain Lane 2014-12-23 21:09:02 UTC
Created attachment 293299 [details] [review]
password: Use gtk-dialogs-use-header GtkSetting
Comment 4 Iain Lane 2014-12-23 21:09:06 UTC
Created attachment 293300 [details] [review]
request-dialog: Use gtk-dialogs-use-header GtkSetting
Comment 5 Iain Lane 2014-12-23 21:09:11 UTC
Created attachment 293301 [details] [review]
delete: Use gtk-dialogs-use-header GtkSetting
Comment 6 Iain Lane 2014-12-23 21:09:15 UTC
Created attachment 293302 [details] [review]
dlg-add: Respect the DialogsUseHeader gtksetting

Put the 'Options' button in the action area if we're not using the
headerbar.
Comment 7 Iain Lane 2015-01-08 17:07:07 UTC
Created attachment 294115 [details] [review]
fr-new-archive-dialog: respect gtk-dialogs-use-header
Comment 8 Paolo Bacchilega 2015-02-15 12:00:12 UTC
patches applied to master, thank you.
Comment 9 Iain Lane 2015-02-15 12:34:16 UTC
Thanks (& for cleanups too)!