GNOME Bugzilla – Bug 741925
Respect Gtk/DialogsUseHeader for dialogs
Last modified: 2015-02-15 12:34:16 UTC
In 3.14, dialogs started using headerbars unconditionally. Not all environments want this. Fortunately there is a GtkSetting to express this - this patch series is about respecting that setting. The snag is that this is a construct-only property, so we have to move the GtkDialog out into code to set the value at construct time. The idea is that there's no change for the headerbar case, and the buttons move to the action area for the non-headerbar. Test it with something like: gsettings set org.gnome.settings-daemon.plugins.xsettings overrides "{'Gtk/DialogsUseHeader': <0>}"
Created attachment 293297 [details] [review] Respect use-header-bar for the properties dialog This is a construct-only property so you cannot set this from a .ui file.
Created attachment 293298 [details] [review] ask-password: Use gtk-dialogs-use-header GtkSetting
Created attachment 293299 [details] [review] password: Use gtk-dialogs-use-header GtkSetting
Created attachment 293300 [details] [review] request-dialog: Use gtk-dialogs-use-header GtkSetting
Created attachment 293301 [details] [review] delete: Use gtk-dialogs-use-header GtkSetting
Created attachment 293302 [details] [review] dlg-add: Respect the DialogsUseHeader gtksetting Put the 'Options' button in the action area if we're not using the headerbar.
Created attachment 294115 [details] [review] fr-new-archive-dialog: respect gtk-dialogs-use-header
patches applied to master, thank you.
Thanks (& for cleanups too)!