Created attachment 293208 [details] [review]
build: Require mpfr.h

The MPFR library is a requirement, but since it does not ship with a
pkg-config file, we need to do a check on the header.

btw, the compilation error from the build bot:

../../src/number.c:34:18: fatal error: mpfr.h: No such file or directory
 #include "mpfr.h"
                  ^
compilation terminated.
Makefile:867: recipe for target 'number.o' failed
make[2]: *** [number.o] Error 1
make[2]: *** Waiting for unfinished jobs....

Review of attachment 293208 [details] [review]:

Committed.. :)

Thank you for the patch.

thanks; I won't be able to unpin Calculator in Continuous until we can build this new dependency, though, and MPFR does not have a Git repository (which is what gnome-continuous understands).

Can't we make gnome-continuous understand git-svn? It practically gives git like interface on svn repository.

Or alternatively, can we setup a mirror repository of MPFR on git?

I'm not in charge of GNOME Continuous, nor I want to make and maintain an MPFR repository on git.gnome.org by myself.

if you want to open a mirror on github, and maintain it, then I'd be very happy to unpin gnome-calculator.

otherwise, we'll have to wait until Colin Walters is available to have his opinion.

(In reply to comment #4)
> thanks; I won't be able to unpin Calculator in Continuous until we can build
> this new dependency, though, and MPFR does not have a Git repository (which is
> what gnome-continuous understands).

You should build it from a tarball release. You'll also need to add GMP in order to build MPFR.

added GMP and MPFR to the manifest using tarballs, and unpinned gnome-calculator. I think we can close this.

From my perspective, git is preferable, but doing what jhbuild does is generally fine. Nowadays that's usually only tarballs or git, very few things use SVN.