After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741869 - Need full color variant for mark-location
Need full color variant for mark-location
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks: 658553 742514
 
 
Reported: 2014-12-22 16:57 UTC by Andreas Nilsson
Modified: 2015-01-12 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
source icons (52.75 KB, image/svg+xml)
2014-12-22 16:58 UTC, Andreas Nilsson
  Details
Add fullcolor mark-location (62.76 KB, patch)
2014-12-23 11:12 UTC, Jonas Danielsson
none Details | Review
Cast of using the icon in contacts and maps (691.32 KB, video/webm)
2014-12-23 11:14 UTC, Jonas Danielsson
  Details
source icons without the number on it (51.45 KB, image/svg+xml)
2015-01-07 10:14 UTC, Andreas Nilsson
  Details
Add fullcolor mark-location (51.04 KB, patch)
2015-01-07 10:38 UTC, Jonas Danielsson
none Details | Review
mark-location fullcolor variant (59.26 KB, patch)
2015-01-12 13:54 UTC, Jakub Steiner
none Details | Review

Description Andreas Nilsson 2014-12-22 16:57:25 UTC
Needed for GNOME Maps and GNOME Contacts.
Comment 1 Andreas Nilsson 2014-12-22 16:58:04 UTC
Created attachment 293195 [details]
source icons
Comment 2 Jonas Danielsson 2014-12-23 11:12:47 UTC
Created attachment 293244 [details] [review]
Add fullcolor mark-location
Comment 3 Jonas Danielsson 2014-12-23 11:14:56 UTC
Created attachment 293245 [details]
Cast of using the icon in contacts and maps

So, I hope I did the patch correct, first time. I added the src file and ran the render-icon-theme script.

The video show how this looks in the applications. What do you think?
Comment 4 Jakub Steiner 2014-12-23 19:32:30 UTC
the 'I' on the pin was meant to be '1', signifying there would be multiple numbered POI. We should probably drop that.
Comment 5 Andreas Nilsson 2015-01-05 16:32:07 UTC
(In reply to comment #4)
> the 'I' on the pin was meant to be '1', signifying there would be multiple
> numbered POI. We should probably drop that.

Sure.
I'll fix that once I come back from vacation.
Comment 6 Andreas Nilsson 2015-01-07 10:14:54 UTC
Created attachment 294013 [details]
source icons without the number on it

Updated version
Comment 7 Jonas Danielsson 2015-01-07 10:38:28 UTC
Created attachment 294014 [details] [review]
Add fullcolor mark-location
Comment 8 Jonas Danielsson 2015-01-07 10:39:09 UTC
Thanks!

Now that the marker lacks a number, should it sill have that sunken in circle where the number was?
Comment 9 Andreas Nilsson 2015-01-07 11:51:55 UTC
(In reply to comment #8)
> Thanks!
> 
> Now that the marker lacks a number, should it sill have that sunken in circle
> where the number was?

I think so, most pins [1,2] tends to have some kind of dot in the middle, but jimmac drew the original, I'll trust his take on it.

1. http://2.bp.blogspot.com/-miAmF06dDKc/ULoyeJd9gXI/AAAAAAAAAKg/xN763RkmdUQ/s1600/Map_pin.png
2. https://images.duckduckgo.com/iu/?u=http%3A%2F%2Ffreebiesbug.com%2Fwp-content%2Fuploads%2F2013%2F03%2Fmap-markers-pins-psd.jpg&f=1
Comment 10 Jakub Steiner 2015-01-12 13:54:15 UTC
Created attachment 294347 [details] [review]
mark-location fullcolor variant

- the inset round surface for the number felt out of place without
  the number so I tweaked the surface treatment a little.