GNOME Bugzilla – Bug 741822
Fails to build with VS 2015
Last modified: 2015-07-23 08:35:08 UTC
The next release of VS 2015 removes the internal function __wgetmainargs(). This is used in gspawn-win32-helper.c (also in gio/tests/gio-du.c) and I believe could easily be replaced with g_win32_get_command_line ().
Created attachment 293137 [details] [review] Replace usage of __wgetmainargs()
Created attachment 293138 [details] [review] Fix leak in g_win32_get_command_line()
Review of attachment 293137 [details] [review]: Patch looks good to me.
Review of attachment 293138 [details] [review]: Sure.
Commited as 3cc349b04e76880a9d2f3c3d2195d171e110f66c and b65287fea54eea8979914b06ff44adea4bc809cc
Comment on attachment 293138 [details] [review] Fix leak in g_win32_get_command_line() >From 7f6258782d0aa725782504532bbfba9f006e86bc Mon Sep 17 00:00:00 2001 >From: TingPing <tingping@tingping.se> >Date: Sat, 20 Dec 2014 18:59:15 -0500 >Subject: [PATCH 2/2] win32: Fix leak in g_win32_get_command_line() > >--- > glib/gwin32.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/glib/gwin32.c b/glib/gwin32.c >index ffc5fe2..b7c65bf 100644 >--- a/glib/gwin32.c >+++ b/glib/gwin32.c >@@ -651,5 +651,6 @@ g_win32_get_command_line (void) > result[i] = g_utf16_to_utf8 (args[i], -1, NULL, NULL, NULL); > result[i] = NULL; > >+ LocalFree (args); > return result; > } >-- >2.1.0 >