After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741807 - Add thread name support on OS X and iOS
Add thread name support on OS X and iOS
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gthread
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-12-20 16:08 UTC by Ilya Konstantinov
Modified: 2015-01-26 09:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against git c447bc7f93fbc6e1aaf7f46eef9da2f820c8f209 (1.26 KB, patch)
2014-12-20 16:08 UTC, Ilya Konstantinov 		none Details | Review
Patch against git c447bc7f93fbc6e1aaf7f46eef9da2f820c8f209 (1.41 KB, patch)
2014-12-20 16:19 UTC, Ilya Konstantinov 		accepted-commit_now Details | Review
gthread: add thread name support on Mac OS (1.81 KB, patch)
2015-01-26 09:06 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Ilya Konstantinov 2014-12-20 16:08:17 UTC 
Created attachment 293128 [details] [review]
Patch against git c447bc7f93fbc6e1aaf7f46eef9da2f820c8f209

glib has thread name support on Linux only. Thread names greatly help debugging.

pthread_setname_np(const char*) exists since OS X 10.6 and iOS 3.2. The signature differs slightly from BSD pthread_setname_np(pthread_t, const char*) but fits our use. An autoconf check should be designed to test for it.

Further patches should address BSD and Win32.
Comment 1 Ilya Konstantinov 2014-12-20 16:19:05 UTC 
Created attachment 293129 [details] [review]
Patch against git c447bc7f93fbc6e1aaf7f46eef9da2f820c8f209
Comment 2 Allison Karlitskaya (desrt) 2014-12-20 16:26:24 UTC 
Review of attachment 293129 [details] [review]:

Thanks for the patch and thanks for taking care to check the number of arguments accepted in configure.ac.
Comment 3 Ilya Konstantinov 2015-01-25 19:01:44 UTC 
Ryan, pinging you since it's been a month. Is this patch going into master?
Comment 4 Allison Karlitskaya (desrt) 2015-01-26 09:06:02 UTC 
Created attachment 295424 [details] [review]
gthread: add thread name support on Mac OS
Comment 5 Allison Karlitskaya (desrt) 2015-01-26 09:07:31 UTC 
Attachment 295424 [details] pushed as 2a0c180 - gthread: add thread name support on Mac OS


Sorry for not pushing this.  I assumed that you had commit access for
yourself and was expecting you to push it.

Thanks again.