After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741781 - Fix color of add button on add to app folder dialog
Fix color of add button on add to app folder dialog
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-12-19 19:45 UTC by Michael Catanzaro
Modified: 2014-12-19 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix color of add button on add to app folder dialog (3.49 KB, patch)
2014-12-19 19:45 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-12-19 19:45:02 UTC 
The add button on the add to app folder dialog is missing the suggested-action style class, which was clearly intended.
Comment 1 Michael Catanzaro 2014-12-19 19:45:03 UTC 
Created attachment 293090 [details] [review]
Fix color of add button on add to app folder dialog

This button should be blue when sensitive.

Instead of manually packing the buttons into the header bar, let GTK+
handle them, so we don't screw with its heuristics for setting the color
of the buttons.

https://developer.gnome.org/Dialogs/
Comment 2 Richard Hughes 2014-12-19 20:23:55 UTC 
Review of attachment 293090 [details] [review]:

Looks good, thanks.
Comment 3 Michael Catanzaro 2014-12-19 21:16:56 UTC 
Attachment 293090 [details] pushed as 5fa5a35 - Fix color of add button on add to app folder dialog