GNOME Bugzilla – Bug 741763
Example Makefile.am improvements
Last modified: 2014-12-29 14:31:15 UTC
A few improvements to the examples/Makefile.am to simplify it, adding some more logic to gtk-doc.make to ensure the user has to do less stuff manually.
Created attachment 293050 [details] [review] examples: Remove outdated variables from example Makefile.am Everyone has automake 1.6 now. Specifying EXTRA_DIST is a bit pointless.
Created attachment 293051 [details] [review] examples: Enable gtk-doc `make check` tests by default Otherwise they never get enabled. If people have problems getting the tests to pass, they should either fix their documents, or we should make the tests cleverer.
Created attachment 293052 [details] [review] make: Automatically clean sections.txt if --rebuild-sections is used Rather than documenting it in a comment in the example Makefile.am; might as well automate it.
Created attachment 293053 [details] [review] make: Use $(expand_content_files) wherever $(content_files) is used This means we can eliminate the advice that all $(expand_content_files) entries must also be in $(content_files), simplifying people’s makefiles a little.
Review of attachment 293050 [details] [review]: Looks good, the EXTRA_DIST was meant as an example.
Review of attachment 293051 [details] [review]: +100
Review of attachment 293052 [details] [review]: Thanks!
Review of attachment 293053 [details] [review]: LGTM
The following fixes have been pushed: 7a9ae69 make: Use $(expand_content_files) wherever $(content_files) is used bea2c36 make: Automatically clean sections.txt if --rebuild-sections is used 0349425 examples: Enable gtk-doc `make check` tests by default cebfe06 examples: Remove outdated variables from example Makefile.am
Created attachment 293436 [details] [review] make: Use $(expand_content_files) wherever $(content_files) is used This means we can eliminate the advice that all $(expand_content_files) entries must also be in $(content_files), simplifying people’s makefiles a little.
Created attachment 293437 [details] [review] make: Automatically clean sections.txt if --rebuild-sections is used Rather than documenting it in a comment in the example Makefile.am; might as well automate it.
Created attachment 293438 [details] [review] examples: Enable gtk-doc `make check` tests by default Otherwise they never get enabled. If people have problems getting the tests to pass, they should either fix their documents, or we should make the tests cleverer.
Created attachment 293439 [details] [review] examples: Remove outdated variables from example Makefile.am Everyone has automake 1.6 now. Specifying EXTRA_DIST is a bit pointless.