After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741762 - media-keys: Make power-actions non-interactive based on mode
media-keys: Make power-actions non-interactive based on mode
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-12-19 13:42 UTC by Florian Müllner
Modified: 2015-01-06 00:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-keys: Make power-actions non-interactive based on mode (6.91 KB, patch)
2014-12-19 13:42 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-12-19 13:42:29 UTC 
Follow-up from bug 711682, see patch.
Comment 1 Florian Müllner 2014-12-19 13:42:31 UTC 
Created attachment 293048 [details] [review]
media-keys: Make power-actions non-interactive based on mode

gnome-shell does not allow to grab any particular key combo more
than once, even when the corresponding keybinding modes don't
overlap, so the FOO_KEY_NO_DIALOG shortcuts introduced in commit
b7827c13d823 never actually worked.
Instead, use the new 'action-mode' parameter that was added to the
'Activated' signal to determine whether to a power action should
be interactive or not.
Comment 2 Bastien Nocera 2015-01-05 23:50:56 UTC 
Review of attachment 293048 [details] [review]:

Looks good!
Comment 3 Florian Müllner 2015-01-06 00:37:02 UTC 
Attachment 293048 [details] pushed as 8d41708 - media-keys: Make power-actions non-interactive based on mode