After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741756 - Some type-ahead fixes
Some type-ahead fixes
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-19 11:26 UTC by Florian Müllner
Modified: 2014-12-19 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
entryArea: Disable type-ahead for insensitive entries (966 bytes, patch)
2014-12-19 11:26 UTC, Florian Müllner 		committed Details | Review
entryArea: Enable type-ahead for shift-only key combos (1.03 KB, patch)
2014-12-19 11:26 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-12-19 11:26:35 UTC 
See patches.
Comment 1 Florian Müllner 2014-12-19 11:26:37 UTC 
Created attachment 293041 [details] [review]
entryArea: Disable type-ahead for insensitive entries

The entry is not supposed to be focusable while the entry area is
disabled (usually because the room is currently not connected),
so don't let type-ahead handling bypass that.
Comment 2 Florian Müllner 2014-12-19 11:26:41 UTC 
Created attachment 293042 [details] [review]
entryArea: Enable type-ahead for shift-only key combos

We need to filter out key events with modifiers for type-ahead, so
that keyboard shortcuts don't unexpectedly move focus. However a
shift-only key combo is generally not a shortcut, but an upper
case letter, so do not filter those out.
Comment 3 Florian Müllner 2014-12-19 11:55:25 UTC 
Attachment 293041 [details] pushed as 4e1dd82 - entryArea: Disable type-ahead for insensitive entries
Attachment 293042 [details] pushed as 6afb3e4 - entryArea: Enable type-ahead for shift-only key combos