After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741746 - Vp8enc produces a segmentation fault
Vp8enc produces a segmentation fault
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-19 08:33 UTC by Jose Antonio Santos Cadenas
Modified: 2015-06-03 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vp8enc: Fix segmentation fault when gst_vide_frame_map fails (3.46 KB, patch)
2014-12-19 08:33 UTC, Jose Antonio Santos Cadenas
none Details | Review

Description Jose Antonio Santos Cadenas 2014-12-19 08:33:35 UTC
Created attachment 293029 [details] [review]
vp8enc: Fix segmentation fault when gst_vide_frame_map fails

I've detected that in some circumstances (don't know exactly when), vp8 encoder produces a segmentation fault. Tracing the coredump it seems that the problems occurs when gst_vide_frame_map fails, it is not controlled and processing continues trying to use data that has not been generated.

I attach a patch that could not be perfect, but at least shows the part that I think that has problems.
Comment 1 Sebastian Dröge (slomo) 2014-12-19 09:15:18 UTC
The bigger question would be, why it fails to map the input buffer. Is this on a special hardware platform? Or what kind of buffer/memory is arriving there?

Is the buffer maybe mapped writeable elsewhere, or do we get the only reference here?


While it's of course correct to check if map() fails, it shouldn't fail in the first place here.
Comment 2 Jose Antonio Santos Cadenas 2014-12-19 11:20:28 UTC
This is happening on a i7 processor, it is a laptop, so no special hardware.

Unfortunately I cannot ask your questions, is something that has happen very rarely so it is difficult to trace.

I'll try to get more data if I found the bug again.
Comment 3 Jose Antonio Santos Cadenas 2015-06-03 12:16:00 UTC
I think that we can close this one I couldn't reproduce it since I filed the bug.