After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741734 - Don't parse non-existing arguments
Don't parse non-existing arguments
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: atkbridge
unspecified
Other All
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-12-18 23:18 UTC by Benjamin Otte (Company)
Modified: 2014-12-19 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't parse non-existing arguments (2.13 KB, patch)
2014-12-18 23:18 UTC, Benjamin Otte (Company)
committed Details | Review

Description Benjamin Otte (Company) 2014-12-18 23:18:15 UTC
The definition of the signal declares 0 arguments, so the listener can't
assume there are any.

Found by Michael Stahl via this valgrind snippet:

==4770== Conditional jump or move depends on uninitialised value(s)
==4770==    at 0x3104C10812: text_selection_changed_event_listener
(event.c:1036)
==4770==    by 0x30EF42160A: signal_emit_unlocked_R (gsignal.c:3519)
==4770==    by 0x30EF42A180: g_signal_emit_valist (gsignal.c:3309)
==4770==    by 0x30EF42A8F9: g_signal_emit_by_name (gsignal.c:3405)
==4770==    by 0x1835EE96:
AtkListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject
const&) (atklistener.cxx:454)
==4770==    by 0x56E46BA:
comphelper::AccessibleEventNotifier::addEvent(unsigned int,
Comment 1 Benjamin Otte (Company) 2014-12-18 23:18:17 UTC
Created attachment 293009 [details] [review]
Don't parse non-existing arguments
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-12-19 10:49:12 UTC
Review of attachment 293009 [details] [review]:

LGTM
Comment 3 Benjamin Otte (Company) 2014-12-19 18:03:45 UTC
Attachment 293009 [details] pushed as 790dc10 - Don't parse non-existing arguments